Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5287

Port HSC ip_isr changesets to LSST

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      We identified in DM-5162 some changesets that still need to be ported from HSC to LSST:

      • f1cee734998f1faf86c02af42ea599b077847eeb: IsrTask: allow fallback to a different filter when loading calibrations
      • 89cd629bb8e1a72a545176311b1ef659358d95af: saturationDetection: apply to overscan as well as image

        Attachments

          Issue Links

          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4796 Allow ISR to fall back to a different filter when loading calibrations

          • Invalid
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-5525 Regions checked for saturation need refining

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5436 Create unit test for ip_isr fallbackfilter

          • To Do
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5162 Audit the LSST and HSC codebases for differences

          • Done

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Rebased the repo, and cleaned up a few things you mentioned. Take a look whenever you want. I will look at either modifying a unit test, or creating a ticket before merging this though. I may get to that this weekend, if not monday

            Show
            nlust Nate Lust added a comment - Rebased the repo, and cleaned up a few things you mentioned. Take a look whenever you want. I will look at either modifying a unit test, or creating a ticket before merging this though. I may get to that this weekend, if not monday
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good. Thanks.

            Show
            tjenness Tim Jenness added a comment - Looks good. Thanks.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Nate Lust: Given that we are two days off the end of the cycle, please prefer creating a new ticket for the tests rather than trying to squeeze them in here. It's not a problem to start working next cycle's tickets before this one closes, but it is a problem to do the reverse

            Show
            swinbank John Swinbank added a comment - Nate Lust : Given that we are two days off the end of the cycle, please prefer creating a new ticket for the tests rather than trying to squeeze them in here. It's not a problem to start working next cycle's tickets before this one closes, but it is a problem to do the reverse
            Hide
            Permalink
            nlust Nate Lust added a comment -

            ticket DM-5436 created

            Show
            nlust Nate Lust added a comment - ticket DM-5436 created
            Hide
            Permalink
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              price Paul Price
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Nate Lust, Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: