Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5288

Port HSC pipe_tasks changesets to LSST

    XMLWordPrintable

    Details

      Description

      We identified in DM-5162 some changesets that still need to be ported from HSC to LSST:

      • 31ab5f02f7722650ad0a0eb4e2f7f8b3e0073366, 0c9a4a06bfb34ed26c72109131ef9f4a8c8f237a: multiBand: save background-subtracted coadd as deepCoadd_calexp
      • e99e140feafe28e6f034143e8ee2ae58e9a9358d: Rejig interface for DetectCoaddSourcesTask to provide non-dataRef-centric API
      • 829ee0cdd605ed027af1fada4446b715d9a5180d: multiband: activate sky objects
      • MeasureMergedCoaddSources.doMatchSources defaults to False
      • ProcessImageConfig.doWriteHeavyFootprintsInSources defaults to False ?
      • 56666e8feba6893ac95fd4982d3e0daf6baf2d34: WcsSelectImagesTask: catch imagePoly is None

      We also noticed some differences:

      • * CalibrateConfig.setDefaults doesn't call parent
      • CalibrateTask.run isn't returning apCorrMap
      • reserveFraction=-1 instead of 0.2

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            I don't know if it needs an RFC, but we definitely need wider agreement than just me. Maybe we should just RFC it.

            Show
            price Paul Price added a comment - I don't know if it needs an RFC, but we definitely need wider agreement than just me. Maybe we should just RFC it.
            Hide
            reiss David Reiss added a comment -

            Paul Price I have finished the review and have no more questions, so feel free to merge.

            Show
            reiss David Reiss added a comment - Paul Price I have finished the review and have no more questions, so feel free to merge.
            Hide
            price Paul Price added a comment -

            Thanks David Reiss!

            We discussed the reserveFraction at Princeton, and agreed to add this as a Subaru override rather than changing the default setting. I've added one more commit in obs_subaru, so please let me know if there are any problems with that:

            price@price-laptop:~/LSST/obs/subaru (tickets/DM-5288=) $ git --no-pager log -1 --patch
            commit 708a24936dd2e164d0c1373a5357ad32747ee71a
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Mar 31 15:33:11 2016 -0400
             
                config: reserve PSF candidates for QA
                
                For HSC SSP, we have been reserving 20% of PSF candidates for QA.
                This setting fell out when the feature was ported to LSST.
             
            diff --git a/config/processCcd.py b/config/processCcd.py
            index 72e99a5..692bc7c 100644
            --- a/config/processCcd.py
            +++ b/config/processCcd.py
            @@ -15,6 +15,7 @@ config.charImage.detectAndMeasure.detection.background.binSize = 128
             config.calibrate.detectAndMeasure.detection.background.binSize = 128
             
             # PSF determination
            +config.charImage.measurePsf.reserveFraction = 0.2
             config.charImage.measurePsf.starSelector['objectSize'].sourceFluxField = 'base_PsfFlux_flux'
             try:
                 import lsst.meas.extensions.psfex.psfexPsfDeterminer
            

            I'll run this through Jenkins before merging.

            Show
            price Paul Price added a comment - Thanks David Reiss ! We discussed the reserveFraction at Princeton, and agreed to add this as a Subaru override rather than changing the default setting. I've added one more commit in obs_subaru, so please let me know if there are any problems with that: price@price-laptop:~/LSST/obs/subaru (tickets/DM-5288=) $ git --no-pager log -1 --patch commit 708a24936dd2e164d0c1373a5357ad32747ee71a Author: Paul Price <price@astro.princeton.edu> Date: Thu Mar 31 15:33:11 2016 -0400   config: reserve PSF candidates for QA For HSC SSP, we have been reserving 20% of PSF candidates for QA. This setting fell out when the feature was ported to LSST.   diff --git a/config/processCcd.py b/config/processCcd.py index 72e99a5..692bc7c 100644 --- a/config/processCcd.py +++ b/config/processCcd.py @@ -15,6 +15,7 @@ config.charImage.detectAndMeasure.detection.background.binSize = 128 config.calibrate.detectAndMeasure.detection.background.binSize = 128 # PSF determination +config.charImage.measurePsf.reserveFraction = 0.2 config.charImage.measurePsf.starSelector['objectSize'].sourceFluxField = 'base_PsfFlux_flux' try: import lsst.meas.extensions.psfex.psfexPsfDeterminer I'll run this through Jenkins before merging.
            Hide
            reiss David Reiss added a comment -

            Seems fine to me.

            Show
            reiss David Reiss added a comment - Seems fine to me.
            Hide
            price Paul Price added a comment -

            Thanks again, David Reiss.

            After a final Jenkins run, I've merged everything to master.

            Show
            price Paul Price added a comment - Thanks again, David Reiss . After a final Jenkins run , I've merged everything to master.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              David Reiss
              Watchers:
              David Reiss, John Swinbank, Lauren MacArthur, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.