Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5313

Refine MemManReal implementation per design discussion w/ John

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: xrootd
    • Labels:
      None

      Attachments

        Activity

        Hide
        abh Andy Hanushevsky added a comment -

        Pushed to branch tickets/DM-5313. The code had passed unit tests. Hopefully, no changes will be needed as I won't be around to fix them until April 7th. A pull request is outstanding.

        Show
        abh Andy Hanushevsky added a comment - Pushed to branch tickets/ DM-5313 . The code had passed unit tests. Hopefully, no changes will be needed as I won't be around to fix them until April 7th. A pull request is outstanding.
        Hide
        salnikov Andy Salnikov added a comment - - edited

        Andy, looks OK to me, just some usual if/else indentation that make me stare at it longer than needed Few comments left in PR.

        John, please mark as done when you are done with review.

        Show
        salnikov Andy Salnikov added a comment - - edited Andy, looks OK to me, just some usual if/else indentation that make me stare at it longer than needed Few comments left in PR. John, please mark as done when you are done with review.
        Hide
        jgates John Gates added a comment -

        Looks fine. I put a minor comment in the PR.

        Show
        jgates John Gates added a comment - Looks fine. I put a minor comment in the PR.
        Hide
        jgates John Gates added a comment -

        I made the changes while Andy is away on vacation.

        Show
        jgates John Gates added a comment - I made the changes while Andy is away on vacation.

          People

          Assignee:
          abh Andy Hanushevsky
          Reporter:
          fritzm Fritz Mueller
          Reviewers:
          Andy Salnikov, John Gates
          Watchers:
          Andy Hanushevsky, Andy Salnikov, Fritz Mueller, John Gates
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: