Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5372

Fix obs_* packages and ci tests broken by DM-4683

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc, obs_cfht, obs_decam
    • Labels:
      None

      Description

      The butler changes in DM-4683, in particular the removal of .mapper from the interface exposed by a Butler object, broken obs_cfht, obs_decam, and ci_hsc.

      This issue will fix those changes, and search for additional broken things.

      This work is proceeding in conjunction with DM-5370 to test that the CI system, e.g. lsst_ci, is sensitive to these breakages and fixes.

        Attachments

          Activity

          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          I found it interesting (reassuring?) that the breakage so far has all been tests that were trying to inspect something, but that method of inspection was changed.  It will be good to have CI improved to catch this (DM-5222 to build ci_hsc daily and on Pull Requests is now done and DM-5370 is close).

          But there has been no breakage reported by people actually just using Butler to do things with data. The re-factoring of DM-4692 being the understandable (and understandably frustrating) exception.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - I found it interesting (reassuring?) that the breakage so far has all been tests that were trying to inspect something, but that method of inspection was changed.  It will be good to have CI improved to catch this ( DM-5222 to build ci_hsc daily and on Pull Requests is now done and DM-5370 is close). But there has been no breakage reported by people actually just using Butler to do things with data. The re-factoring of DM-4692 being the understandable (and understandably frustrating) exception.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Quick review. These are all small changes.

          The GitHub Pull Requests are:
          https://github.com/lsst/obs_cfht/pull/10
          https://github.com/lsst/obs_decam/pull/19
          https://github.com/lsst/ci_hsc/pull/7

          (note that the list Pull Request for ci_hsc is using a new mechanism to automatically build pull requests to GitHub using Jenkins. It unfortunately doesn't actually work quite yet, so please ignore the message of failure listed by this pull request.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Quick review. These are all small changes. The GitHub Pull Requests are: https://github.com/lsst/obs_cfht/pull/10 https://github.com/lsst/obs_decam/pull/19 https://github.com/lsst/ci_hsc/pull/7 (note that the list Pull Request for ci_hsc is using a new mechanism to automatically build pull requests to GitHub using Jenkins. It unfortunately doesn't actually work quite yet, so please ignore the message of failure listed by this pull request.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Nate Pease
          The successful manually Jenkins-submitted build is the one listed above, 9013.

          https://ci.lsst.codes/job/stack-os-matrix/9013/label=centos-7/console

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Nate Pease The successful manually Jenkins-submitted build is the one listed above, 9013. https://ci.lsst.codes/job/stack-os-matrix/9013/label=centos-7/console
          Hide
          npease Nate Pease added a comment -

          looks good. thanks.

          Show
          npease Nate Pease added a comment - looks good. thanks.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Merged to master.
          Changes in obs_decam, obs_cfht, ci_hsc.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Merged to master. Changes in obs_decam , obs_cfht , ci_hsc .

            People

            • Assignee:
              wmwood-vasey Michael Wood-Vasey
              Reporter:
              wmwood-vasey Michael Wood-Vasey
              Reviewers:
              Nate Pease
              Watchers:
              Michael Wood-Vasey, Nate Lust, Nate Pease
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel