Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Team:SQuaRE
Description
The butler changes in DM-4683, in particular the removal of .mapper from the interface exposed by a Butler object, broken obs_cfht, obs_decam, and ci_hsc.
This issue will fix those changes, and search for additional broken things.
This work is proceeding in conjunction with DM-5370 to test that the CI system, e.g. lsst_ci, is sensitive to these breakages and fixes.
Attachments
Activity
Quick review. These are all small changes.
The GitHub Pull Requests are:
https://github.com/lsst/obs_cfht/pull/10
https://github.com/lsst/obs_decam/pull/19
https://github.com/lsst/ci_hsc/pull/7
(note that the list Pull Request for ci_hsc is using a new mechanism to automatically build pull requests to GitHub using Jenkins. It unfortunately doesn't actually work quite yet, so please ignore the message of failure listed by this pull request.
Michael Wood-Vasey
added a comment - Quick review. These are all small changes.
The GitHub Pull Requests are:
https://github.com/lsst/obs_cfht/pull/10
https://github.com/lsst/obs_decam/pull/19
https://github.com/lsst/ci_hsc/pull/7
(note that the list Pull Request for ci_hsc is using a new mechanism to automatically build pull requests to GitHub using Jenkins. It unfortunately doesn't actually work quite yet, so please ignore the message of failure listed by this pull request. Nate Pease [X]
The successful manually Jenkins-submitted build is the one listed above, 9013.
https://ci.lsst.codes/job/stack-os-matrix/9013/label=centos-7/console
Michael Wood-Vasey
added a comment - Nate Pease [X]
The successful manually Jenkins-submitted build is the one listed above, 9013.
https://ci.lsst.codes/job/stack-os-matrix/9013/label=centos-7/console looks good. thanks.
Merged to master.
Changes in obs_decam, obs_cfht, ci_hsc.
Michael Wood-Vasey
added a comment - Merged to master.
Changes in obs_decam , obs_cfht , ci_hsc . 
I found it interesting (reassuring?) that the breakage so far has all been tests that were trying to inspect something, but that method of inspection was changed. It will be good to have CI improved to catch this (
DM-5222to build ci_hsc daily and on Pull Requests is now done andDM-5370is close).But there has been no breakage reported by people actually just using Butler to do things with data. The re-factoring of
DM-4692being the understandable (and understandably frustrating) exception.