Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5384

Port SdssShape changes from HSC meas_algorithms to LSST meas_base

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      In porting meas_algorithm changes from HSC to LSST, modifications to the SdssShape algorithm were discovered. These changes should be transferred to LSST.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Nate Lust – am I correct in understanding that you already started work on this?

            Show
            swinbank John Swinbank added a comment - Nate Lust – am I correct in understanding that you already started work on this?
            Hide
            nlust Nate Lust added a comment -

            Let me know if you have any questions

            Show
            nlust Nate Lust added a comment - Let me know if you have any questions
            Hide
            reiss David Reiss added a comment -

            I have no issues with the code, just a thought:
            it would be great to have a test for the case of negative sources.

            Show
            reiss David Reiss added a comment - I have no issues with the code, just a thought: it would be great to have a test for the case of negative sources.
            Hide
            nlust Nate Lust added a comment - - edited

            There is one introduced in meas_algorithms, for historic reasons before the two things were split. In long term it will move but for now it depends on things in that package which is higher up in the install stack.

            Show
            nlust Nate Lust added a comment - - edited There is one introduced in meas_algorithms, for historic reasons before the two things were split. In long term it will move but for now it depends on things in that package which is higher up in the install stack.
            Hide
            reiss David Reiss added a comment -

            In that case how about file a ticket to move that over? And then I'd say this one (DM-5384) is ok to merge.

            Show
            reiss David Reiss added a comment - In that case how about file a ticket to move that over? And then I'd say this one ( DM-5384 ) is ok to merge.
            Hide
            nlust Nate Lust added a comment -

            Created ticket DM-5437

            Show
            nlust Nate Lust added a comment - Created ticket DM-5437
            Hide
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                nlust Nate Lust
                Reviewers:
                David Reiss
                Watchers:
                David Reiss, John Swinbank, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: