Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5392

Please stop leaving repoCfg.yaml files around

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: butler, daf_persistence
    • Labels:
      None

      Description

      After a recent change to daf_persistence and possibly other packages I'm finding that many packages leave repoCfg.yaml files lying around after they run unit tests.

      I'm not sure what is best to do about these files. If they are temporary, as I am guessing, then I think we need some way to clean them up when the tests that generated them have run. If they are intended to be permanent (which would be surprising for auto-generated files) then they should probably be committed?

      I hope we can do better than adding them to .gitignore.

        Attachments

          Activity

          Hide
          npease Nate Pease added a comment -

          They're not needed right now. I'll remove the code that writes them out today.

          Show
          npease Nate Pease added a comment - They're not needed right now. I'll remove the code that writes them out today.
          Hide
          rowen Russell Owen added a comment -

          That is great news. many thanks

          Show
          rowen Russell Owen added a comment - That is great news. many thanks
          Hide
          rowen Russell Owen added a comment -

          It looks like this should work.

          I am confused by Access.setCfg. You have stopped calling it, at least in that one place, but your ticket comments suggest that the feature it implements needs more study before being implemented. Shouldn't you remove it the method? Also, the name seems misleading for something that writes out a file instead of altering internal state.

          Minor typo you might consider fixing: "Implements an butler" in the doc string for Access.

          Show
          rowen Russell Owen added a comment - It looks like this should work. I am confused by Access.setCfg . You have stopped calling it, at least in that one place, but your ticket comments suggest that the feature it implements needs more study before being implemented. Shouldn't you remove it the method? Also, the name seems misleading for something that writes out a file instead of altering internal state. Minor typo you might consider fixing: "Implements an butler" in the doc string for Access.
          Hide
          npease Nate Pease added a comment -

          Access, Storage, PosixStorage are WIP. I have another ticket branch where more work has been done and I don't want to deal with the merge, I just want to solve the immediate problem described by this issue.

          Show
          npease Nate Pease added a comment - Access, Storage, PosixStorage are WIP. I have another ticket branch where more work has been done and I don't want to deal with the merge, I just want to solve the immediate problem described by this issue.
          Hide
          rowen Russell Owen added a comment -

          WIP means works in progress? Fair enough. Thanks for fixing the problem.

          Show
          rowen Russell Owen added a comment - WIP means works in progress? Fair enough. Thanks for fixing the problem.

            People

            • Assignee:
              npease Nate Pease
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              Nate Pease, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel