Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5446

Add scipy as a stack dependency

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      Adding scipy as a stack dependency is still a nebulous term to me. David is going to follow up on how to do this exactly (it's already in conda_packages.txt).

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment - - edited

            There are a number options that I can see:

            1. Go with current protocol and create an EUPS package containing scipy
            2. Hope that RFC-50 can be adopted.
            3. Make scipy an external dependency as for numpy and matplotlib and make a package that simply checks scipy is available. This option is almost what we have now without the checking.

            The first and third options would require scipy to be listed in other table files. Option 3 is by far the easiest to implement.

            Show
            tjenness Tim Jenness added a comment - - edited There are a number options that I can see: Go with current protocol and create an EUPS package containing scipy Hope that RFC-50 can be adopted. Make scipy an external dependency as for numpy and matplotlib and make a package that simply checks scipy is available. This option is almost what we have now without the checking. The first and third options would require scipy to be listed in other table files. Option 3 is by far the easiest to implement.
            Hide
            krughoff Simon Krughoff added a comment -

            I'd say we go with option 3. Option 1 is too much overhead and we can't wait for option 2.

            Show
            krughoff Simon Krughoff added a comment - I'd say we go with option 3. Option 1 is too much overhead and we can't wait for option 2.
            Hide
            reiss David Reiss added a comment -

            Created scipy package and added it to lsstsw/etc/repos.yaml .

            Show
            reiss David Reiss added a comment - Created scipy package and added it to lsstsw/etc/repos.yaml .
            Hide
            reiss David Reiss added a comment -

            Hi Tim,
            Would you mind reviewing the scipy package?
            I also added it to repos.yaml in lsstsw.
            Thanks.

            Show
            reiss David Reiss added a comment - Hi Tim, Would you mind reviewing the scipy package? I also added it to repos.yaml in lsstsw . Thanks.
            Hide
            tjenness Tim Jenness added a comment -

            Looks good although I don't think the .cfg file is needed. Also, I'd like the table files of other packages to be fixed as soon as possible so that we have an idea of what is silently depending on scipy. From what I can see this is afw, ip_diffim, meas_modelfit, mops_daymops, pipe_tasks, shapelet and sims_photUtils. I realise you may not want to do that on this ticket but I really do want these dependencies to be fixed sooner rather than later. Many of these are setupOptional that we should consider making mandatory. Some will be setupRequired.

            Show
            tjenness Tim Jenness added a comment - Looks good although I don't think the .cfg file is needed. Also, I'd like the table files of other packages to be fixed as soon as possible so that we have an idea of what is silently depending on scipy. From what I can see this is afw , ip_diffim , meas_modelfit , mops_daymops , pipe_tasks , shapelet and sims_photUtils . I realise you may not want to do that on this ticket but I really do want these dependencies to be fixed sooner rather than later. Many of these are setupOptional that we should consider making mandatory. Some will be setupRequired .
            Hide
            reiss David Reiss added a comment - - edited

            OK, I'll make a new ticket.
            DM-5658.

            Show
            reiss David Reiss added a comment - - edited OK, I'll make a new ticket. DM-5658 .
            Hide
            reiss David Reiss added a comment -

            Merged. Thanks for your help, Tim.

            Show
            reiss David Reiss added a comment - Merged. Thanks for your help, Tim.

              People

              Assignee:
              reiss David Reiss
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Tim Jenness
              Watchers:
              David Reiss, Kian-Tat Lim, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.