Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5453

Failure in ci_hsc: syntax error in obs_subaru's config/measureCoaddSources.py

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc, obs_subaru
    • Labels:
      None
    • Story Points:
      0.1
    • Sprint:
      DRP W16-7
    • Team:
      Data Release Production

      Description

      The Jenkins build of ci_hsc is failing:

      [2016-03-15T00:41:10.959702Z]   File "/home/build0/lsstsw/stack/Linux64/obs_subaru/tickets.DM-5453-g53dd454477/config/measureCoaddSources.py", line 14
      [2016-03-15T00:41:10.959725Z]     config.astrometry.refObjLoader.load(getPackageDir("obs_subaru"), "config", "filterMap.py"))
      [2016-03-15T00:41:10.959747Z]                                                                                               ^
      [2016-03-15T00:41:10.959755Z] SyntaxError: invalid syntax
      [2016-03-15T00:41:11.009328Z] scons: *** [.scons/measure] Error 1
      [2016-03-15T00:41:11.011114Z] scons: building terminated because of errors.
      

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Sorry, my fault. I forgot to merge obs_subaru for DM-5280.

          Show
          price Paul Price added a comment - Sorry, my fault. I forgot to merge obs_subaru for DM-5280 .
          Hide
          swinbank John Swinbank added a comment -

          I hit another problem in ci_hsc while testing the fix for this (which was subsequently superseded by DM-5280). Since the fix is already sitting on this ticket branch, I'm going to reopen this and repurpose it for that, and get Paul Price to review it (that'll teach him).

          Show
          swinbank John Swinbank added a comment - I hit another problem in ci_hsc while testing the fix for this (which was subsequently superseded by DM-5280 ). Since the fix is already sitting on this ticket branch, I'm going to reopen this and repurpose it for that, and get Paul Price to review it (that'll teach him).
          Hide
          price Paul Price added a comment -

          Your second commit ("Handle ANetAstrometryTask ref object loader") undoes the fix from the first commit (missing os.path.join). I've fixed things up for you (and massaged the commit message so it doesn't violate line length limits). Good to merge if you approve the final product and it passes Jenkins.

          Show
          price Paul Price added a comment - Your second commit ("Handle ANetAstrometryTask ref object loader") undoes the fix from the first commit (missing os.path.join ). I've fixed things up for you (and massaged the commit message so it doesn't violate line length limits). Good to merge if you approve the final product and it passes Jenkins.
          Hide
          price Paul Price added a comment -

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-5453=) $ git sub
          commit 642c427ec3e54009adff8919cf22166bb0406d62
          Author: John Swinbank <swinbank@princeton.edu>
          Date:   Mon Mar 14 20:56:25 2016 -0400
           
              Fix syntax error in config override.
           
           config/measureCoaddSources.py | 2 +-
           1 file changed, 1 insertion(+), 1 deletion(-)
           
          commit acac76094f23ef95c2c396bb7380e3f003fdaf48
          Author: John Swinbank <swinbank@princeton.edu>
          Date:   Mon Mar 14 22:45:19 2016 -0400
           
              Handle ANetAstrometryTask ref object loader.
              
              The default AstrometryTask provides a retargetable refObjLoader subtask.
              ANetAstrometryTask doesn't; rather, it delegates to a solver subtask.
              This assumes that it is loading astrometry.net reference data, so the
              refObjLoader is not retargetable -- but the solver subtask can load the
              filter map directly.
           
           config/measureCoaddSources.py | 8 +++++++-
           1 file changed, 7 insertions(+), 1 deletion(-)
          

          Show
          price Paul Price added a comment - price@price-laptop:~/LSST/obs/subaru (tickets/DM-5453=) $ git sub commit 642c427ec3e54009adff8919cf22166bb0406d62 Author: John Swinbank <swinbank@princeton.edu> Date: Mon Mar 14 20:56:25 2016 -0400   Fix syntax error in config override.   config/measureCoaddSources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   commit acac76094f23ef95c2c396bb7380e3f003fdaf48 Author: John Swinbank <swinbank@princeton.edu> Date: Mon Mar 14 22:45:19 2016 -0400   Handle ANetAstrometryTask ref object loader. The default AstrometryTask provides a retargetable refObjLoader subtask. ANetAstrometryTask doesn't; rather, it delegates to a solver subtask. This assumes that it is loading astrometry.net reference data, so the refObjLoader is not retargetable -- but the solver subtask can load the filter map directly.   config/measureCoaddSources.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
          Hide
          price Paul Price added a comment -

          After another change (squashed into the second commit), it passes Jenkins.

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-5453=) $ git sub
          commit 642c427ec3e54009adff8919cf22166bb0406d62
          Author: John Swinbank <swinbank@princeton.edu>
          Date:   Mon Mar 14 20:56:25 2016 -0400
           
              Fix syntax error in config override.
           
           config/measureCoaddSources.py | 2 +-
           1 file changed, 1 insertion(+), 1 deletion(-)
           
          commit 0134163a66f14968dc226b2228683add83b649bd
          Author: John Swinbank <swinbank@princeton.edu>
          Date:   Mon Mar 14 22:45:19 2016 -0400
           
              Handle ANetAstrometryTask ref object loader.
              
              The default AstrometryTask provides a retargetable refObjLoader subtask.
              ANetAstrometryTask doesn't; rather, it delegates to a solver subtask.
              This assumes that it is loading astrometry.net reference data, so the
              refObjLoader is not retargetable -- but the solver subtask can load the
              filter map directly.
           
           config/hsc/measureCoaddSources.py | 11 +++++++++--
           config/measureCoaddSources.py     |  8 +++++++-
           2 files changed, 16 insertions(+), 3 deletions(-)
          

          Show
          price Paul Price added a comment - After another change (squashed into the second commit), it passes Jenkins . price@price-laptop:~/LSST/obs/subaru (tickets/DM-5453=) $ git sub commit 642c427ec3e54009adff8919cf22166bb0406d62 Author: John Swinbank <swinbank@princeton.edu> Date: Mon Mar 14 20:56:25 2016 -0400   Fix syntax error in config override.   config/measureCoaddSources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   commit 0134163a66f14968dc226b2228683add83b649bd Author: John Swinbank <swinbank@princeton.edu> Date: Mon Mar 14 22:45:19 2016 -0400   Handle ANetAstrometryTask ref object loader. The default AstrometryTask provides a retargetable refObjLoader subtask. ANetAstrometryTask doesn't; rather, it delegates to a solver subtask. This assumes that it is loading astrometry.net reference data, so the refObjLoader is not retargetable -- but the solver subtask can load the filter map directly.   config/hsc/measureCoaddSources.py | 11 +++++++++-- config/measureCoaddSources.py | 8 +++++++- 2 files changed, 16 insertions(+), 3 deletions(-)
          Hide
          swinbank John Swinbank added a comment -

          Thanks, Paul, and apologies for unfixing my own fix – that's what I get for trying to solve issues when half asleep.

          Show
          swinbank John Swinbank added a comment - Thanks, Paul, and apologies for unfixing my own fix – that's what I get for trying to solve issues when half asleep.
          Hide
          swinbank John Swinbank added a comment -

          Merged.

          Show
          swinbank John Swinbank added a comment - Merged.

            People

            • Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Watchers:
              John Swinbank, Kian-Tat Lim, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel