Fix Version/s: None
Sprint:Alert Production X16 - 5, Alert Production F16 - 6
At the moment some preliminary code is on ticket branches, but this need to be redone once the RFC is finished.
DM-6356 Add linearity correction to obs_decam
- is blocked by
DM-6147 Set SUSPECT mask in ISR task and make saturation a double
- is triggered by
RFC-164 Unifying non-linearity correction in the ISR task
- is triggering
DM-6514 Minor fixes to linearization
- relates to
RFC-190 Use nan for saturation level to prevent masking
I realized I had forgotten to update the camera generating code for those obs packages that use such. Fixed. I cleaned up some code in obs_decam at the same time (as a separate commit).
I disagree about the API, but I don't think it's so important. Thank you for thinking about it and considering my ideas.
I added some comments to the afw github PR about the test functions; nothing major.
Thank you for all the clean ups!
Russell Owen do you want to add entries for the two new test routines into the developer guide now that we have entries for those types of routines in that document.
Your points about the unit tests are well taken. I think I have fully addressed them as follows:
Regarding the linearization functors: I plan to keep the current API for the following reasons:
Regarding out of range pixels: you raise a good point. However, pixels that are too large for the table will already be flagged as SAT or SUSPECT unless the table has a range that that is crazily too small. Pixels that are too small can safely be left alone, and we have no reasonable flag for them. It is conceivable that too-large pixels should trigger an exception (and that would be a trivial change); I think that is not needed for too-small pixels.
Regarding obs_subaru: I split the commit into two pieces: first standardize suspect masking, then linearize using the new code. I think it is a small a set of changes as makes sense. I also modified the log calls as you requested and fixed some pyflakes warnings and errors (in a few additional commits) while I was at it.
Please have another look.