Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5503

Implement single interface to sanitized exposure metadata

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      Alert Production F16 - 7, Alert Production F16 - 8, Alert Production F16 - 9, Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      Currently metadata associated with exposures is accessed in a few different ways: through the Calib object, through the Wcs object, and through the metadata object.

      In conjunction with DM-5502, which is to figure out what metadata is needed, this will provide a single interface to exposure oriented metadata. One tricky thing is that the Calib object has some subset of the metadata we'll need in a sanitized form, but we won't want to have to remember where to look for metadata. If we can't extend the Calib object to hold all sanitized metadata, we should create a new metadata object to store all sanitized metadata and remove the pieces from Calib that are currently there.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6624 make jointcal integration/validation test for DECam

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6625 make jointcal integration/validation test for lsstSim

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5502 Collect usage of header metadata

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-7587 Add timesys argument to DateTime constructor to toString (implement RFC-219)

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-199 Add new metadata to ExposureInfo

          • Adopted

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-217 Improve support for ExposureInfo in Exposure

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-238 DateTime() should support invalid dates

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7790 Move FITS header documentation from afw/doc

          • Won't Fix
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-7976 coadd cannot be loaded directly as afw.image.ExposureF

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-7745 enum constants in daf_base.DateTime can cause confusion

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-8015 VisitInfo repr() and str() should print a useful summary of contents

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8170 Catalogs should have a version number

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6621 cleanup non-survey-generic python in jointcal

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8034 reprocess validation_data* to contain VisitInfo

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8052 Load LST into VisitInfo

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8053 Load ERA into VisitInfo

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8962 Set darktime in makeRawVisitInfo

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6906 Update DateTime to reflect 2017-01-01 leap second

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8008 VisitInfo.h should be #included in image.h

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-7537 Add a unit test for ExposureInfo

          • Invalid

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-219 Add support to daf::base::DateTime for TAI strings

          • Implemented

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7565 Add bbox to ExposureInfo

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7624 Modernize obs_cfht tests to support pytest

          • Invalid
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            17 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Cool about the calexps. I guess we'll find out once we push twinkles through it?

            I skimmed things over, and I think it looks ok for jointcal, but I can't be sure until I try to use it. We can sort out how to lift the obs*tests into obs_base later: it looks like there's a perfect case for unifying the test framework.

            Show
            Parejkoj John Parejko added a comment - Cool about the calexps. I guess we'll find out once we push twinkles through it? I skimmed things over, and I think it looks ok for jointcal, but I can't be sure until I try to use it. We can sort out how to lift the obs*tests into obs_base later: it looks like there's a perfect case for unifying the test framework.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Jim Bosch realized the code was missing an important feature: the ability to read older ExposureInfo and Calib tables. I fixed this, though some of it feels a bit hackish because tables do not intrinsically have an associated version number.

            I also cleaned up flake8 warnings and standardized imports in the unit tests.

            Jim Bosch could you please look over these changes? They start at commit b6b3643 "Support old versions of Exposure and Calib tables". Do as you like with the unit test changes; it's a lot of minor changes to a huge number of files and I can pass it off to somebody else if you prefer. But if you can glance at them, that'd be great.

            I will also run everything through Jenkins py2 and py3, including ci_hsc for the former before merging.

            Show
            rowen Russell Owen added a comment - - edited Jim Bosch realized the code was missing an important feature: the ability to read older ExposureInfo and Calib tables. I fixed this, though some of it feels a bit hackish because tables do not intrinsically have an associated version number. I also cleaned up flake8 warnings and standardized imports in the unit tests. Jim Bosch could you please look over these changes? They start at commit b6b3643 "Support old versions of Exposure and Calib tables". Do as you like with the unit test changes; it's a lot of minor changes to a huge number of files and I can pass it off to somebody else if you prefer. But if you can glance at them, that'd be great. I will also run everything through Jenkins py2 and py3, including ci_hsc for the former before merging.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Review complete (again); comments on the afw PR.

            Show
            jbosch Jim Bosch added a comment - Review complete (again); comments on the afw PR.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you for reviewing the C++ table changes, Jim Bosch. I made your suggested changes and it all passed Jenkins py2 and py3 (the latter after a minor tweak to a test in daf_butlerUtils). Merged.

            Show
            rowen Russell Owen added a comment - Thank you for reviewing the C++ table changes, Jim Bosch . I made your suggested changes and it all passed Jenkins py2 and py3 (the latter after a minor tweak to a test in daf_butlerUtils). Merged.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            This change is described on community here:

            https://community.lsst.org/t/unified-exposure-metadata/1214

            Show
            rowen Russell Owen added a comment - - edited This change is described on community here: https://community.lsst.org/t/unified-exposure-metadata/1214

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Jim Bosch
              Watchers:
              Dominique Boutigny, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Paul Price, Pim Schellart [X] (Inactive), Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.