Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5503

Implement single interface to sanitized exposure metadata

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Templates:
    • Story Points:
      10
    • Sprint:
      Alert Production F16 - 7, Alert Production F16 - 8, Alert Production F16 - 9, Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      Currently metadata associated with exposures is accessed in a few different ways: through the Calib object, through the Wcs object, and through the metadata object.

      In conjunction with DM-5502, which is to figure out what metadata is needed, this will provide a single interface to exposure oriented metadata. One tricky thing is that the Calib object has some subset of the metadata we'll need in a sanitized form, but we won't want to have to remember where to look for metadata. If we can't extend the Calib object to hold all sanitized metadata, we should create a new metadata object to store all sanitized metadata and remove the pieces from Calib that are currently there.

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          Cool about the calexps. I guess we'll find out once we push twinkles through it?

          I skimmed things over, and I think it looks ok for jointcal, but I can't be sure until I try to use it. We can sort out how to lift the obs*tests into obs_base later: it looks like there's a perfect case for unifying the test framework.

          Show
          Parejkoj John Parejko added a comment - Cool about the calexps. I guess we'll find out once we push twinkles through it? I skimmed things over, and I think it looks ok for jointcal, but I can't be sure until I try to use it. We can sort out how to lift the obs*tests into obs_base later: it looks like there's a perfect case for unifying the test framework.
          Hide
          rowen Russell Owen added a comment - - edited

          Jim Bosch realized the code was missing an important feature: the ability to read older ExposureInfo and Calib tables. I fixed this, though some of it feels a bit hackish because tables do not intrinsically have an associated version number.

          I also cleaned up flake8 warnings and standardized imports in the unit tests.

          Jim Bosch could you please look over these changes? They start at commit b6b3643 "Support old versions of Exposure and Calib tables". Do as you like with the unit test changes; it's a lot of minor changes to a huge number of files and I can pass it off to somebody else if you prefer. But if you can glance at them, that'd be great.

          I will also run everything through Jenkins py2 and py3, including ci_hsc for the former before merging.

          Show
          rowen Russell Owen added a comment - - edited Jim Bosch realized the code was missing an important feature: the ability to read older ExposureInfo and Calib tables. I fixed this, though some of it feels a bit hackish because tables do not intrinsically have an associated version number. I also cleaned up flake8 warnings and standardized imports in the unit tests. Jim Bosch could you please look over these changes? They start at commit b6b3643 "Support old versions of Exposure and Calib tables". Do as you like with the unit test changes; it's a lot of minor changes to a huge number of files and I can pass it off to somebody else if you prefer. But if you can glance at them, that'd be great. I will also run everything through Jenkins py2 and py3, including ci_hsc for the former before merging.
          Hide
          jbosch Jim Bosch added a comment -

          Review complete (again); comments on the afw PR.

          Show
          jbosch Jim Bosch added a comment - Review complete (again); comments on the afw PR.
          Hide
          rowen Russell Owen added a comment -

          Thank you for reviewing the C++ table changes, Jim Bosch. I made your suggested changes and it all passed Jenkins py2 and py3 (the latter after a minor tweak to a test in daf_butlerUtils). Merged.

          Show
          rowen Russell Owen added a comment - Thank you for reviewing the C++ table changes, Jim Bosch . I made your suggested changes and it all passed Jenkins py2 and py3 (the latter after a minor tweak to a test in daf_butlerUtils). Merged.
          Hide
          rowen Russell Owen added a comment - - edited

          This change is described on community here:

          https://community.lsst.org/t/unified-exposure-metadata/1214

          Show
          rowen Russell Owen added a comment - - edited This change is described on community here: https://community.lsst.org/t/unified-exposure-metadata/1214

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Jim Bosch
              Watchers:
              Dominique Boutigny, Ian Sullivan, Jim Bosch, John Parejko, John Swinbank, Paul Price, Pim Schellart, Russell Owen, Simon Krughoff, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile