Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim, meas_algorithms, meas_astrom, meas_extensions_psfex, meas_modelfit
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:Alert Production X16 - 03
-
Team:Alert Production
Description
Implement RFC-154:
- Make star selectors tasks, but continue to use and prefer a registry
- Add an abstract base class for star selectors with the following methods:
- selectStars abstract method that takes a catalog of sources and returns a lsst.pipe.base.Struct containing a catalog of stars
- run concrete method that takes a catalog of sources and an optional name of a flag field, calls selectStars to select stars, then sets the flag field (if given) for stars
- makePsfCandidates make a list of psf candidates from a catalog of stars (does no selection, other than skipping stars that cannot be made into candidates, and logging the rejects)
Attachments
Issue Links
- duplicates
-
DM-3950 Unify API of Source/Star Selectors
- Invalid
- is triggered by
-
RFC-154 Change star selectors to return stars instead of PSF candidates
- Implemented
- is triggering
-
DM-5680 makePsfCandidate needs to be easier and safer to use
- To Do
-
DM-5663 Config override fixes needed due to new star selector
- Done
- relates to
-
DM-6474 Restore star selector registry
- Done
-
DM-5655 Reduce code duplication in StarSelectors
- Won't Fix
-
DM-5578 making PSF candidates should be simpler
- Invalid
-
DM-1102 Test Data - Replace Unit-Test Data Package
- Won't Fix
-
DM-6077 Change PSF determiners into tasks
- Done
It turns out that a registry doesn't build a configurable correctly as a subtask – it is missing some important information, including a log. Rather than put up with this, I plan to ditch the registry and use our standard subtask solution. It standardizes the code and presents one preferred way of doing things instead of two different ways.