Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5532

Change star selectors to return stars instead of PSF candidates

    XMLWordPrintable

    Details

      Description

      Implement RFC-154:

      • Make star selectors tasks, but continue to use and prefer a registry
      • Add an abstract base class for star selectors with the following methods:
      • selectStars abstract method that takes a catalog of sources and returns a lsst.pipe.base.Struct containing a catalog of stars
      • run concrete method that takes a catalog of sources and an optional name of a flag field, calls selectStars to select stars, then sets the flag field (if given) for stars
      • makePsfCandidates make a list of psf candidates from a catalog of stars (does no selection, other than skipping stars that cannot be made into candidates, and logging the rejects)

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            It turns out that a registry doesn't build a configurable correctly as a subtask – it is missing some important information, including a log. Rather than put up with this, I plan to ditch the registry and use our standard subtask solution. It standardizes the code and presents one preferred way of doing things instead of two different ways.

            Show
            rowen Russell Owen added a comment - It turns out that a registry doesn't build a configurable correctly as a subtask – it is missing some important information, including a log. Rather than put up with this, I plan to ditch the registry and use our standard subtask solution. It standardizes the code and presents one preferred way of doing things instead of two different ways.
            Hide
            rowen Russell Owen added a comment -

            Done. The star selectors are now tasks and so have task documentation, but no complete examples due to the lack of easily available calexp and associated star catalogs. Once those become vailable then simple examples will be very easy.

            Show
            rowen Russell Owen added a comment - Done. The star selectors are now tasks and so have task documentation, but no complete examples due to the lack of easily available calexp and associated star catalogs. Once those become vailable then simple examples will be very easy.
            Hide
            jbosch Jim Bosch added a comment -

            I've linked DM-1102 here to at least start to capture that need for better unit test data.

            Show
            jbosch Jim Bosch added a comment - I've linked DM-1102 here to at least start to capture that need for better unit test data.
            Hide
            rowen Russell Owen added a comment - - edited

            There are a few things about this code that make me uneasy. I have listed them on RFC-154.

            Show
            rowen Russell Owen added a comment - - edited There are a few things about this code that make me uneasy. I have listed them on RFC-154 .
            Hide
            rowen Russell Owen added a comment -

            If you have time, Jim, I'd appreciate your reviewing this code (or sanity-checking it if you don't have time for a full review). The registry is gone, which I don't expect you to be happy about, but flagging stars is supported. I am happy to take a final cleanup pass on commits if you like, once we are sure this is the final approach. They commits are fairly clean now (I hope) but show some evolution of the design.

            Show
            rowen Russell Owen added a comment - If you have time, Jim, I'd appreciate your reviewing this code (or sanity-checking it if you don't have time for a full review). The registry is gone, which I don't expect you to be happy about, but flagging stars is supported. I am happy to take a final cleanup pass on commits if you like, once we are sure this is the final approach. They commits are fairly clean now (I hope) but show some evolution of the design.
            Hide
            jbosch Jim Bosch added a comment -

            Looks great overall. I have a few comments on a couple of the PRs, but nothing major.

            Show
            jbosch Jim Bosch added a comment - Looks great overall. I have a few comments on a couple of the PRs, but nothing major.
            Hide
            rowen Russell Owen added a comment -

            Thank you Jim Bosch. I made all requested changes (except I will ask you to file the ticket about making code in one star selector more visible to others, since I didn't understand the use case). I will merge after a successful Jenkins run.

            Show
            rowen Russell Owen added a comment - Thank you Jim Bosch . I made all requested changes (except I will ask you to file the ticket about making code in one star selector more visible to others, since I didn't understand the use case). I will merge after a successful Jenkins run.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Lauren MacArthur, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: