Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5578

making PSF candidates should be simpler

    XMLWordPrintable

    Details

    • Story Points:
      2

      Description

      The code to make PSF candidates is too complicated and repeated in too many places (even after DM-5532). Every time lsst.meas.algorithms.makePsfCandidate is called (except in a few tests) it is called as follows:

                  cand = measAlg.makePsfCandidate(source, mi)
      		 
                  if cand.getWidth() == 0:
      		 
                      cand.setBorderWidth(borderWidth)
      		 
                      cand.setWidth(kernelSize + 2*borderWidth)
      		 
                      cand.setHeight(kernelSize + 2*borderWidth)
      		 
       
      		 
                  im = cand.getMaskedImage().getImage()
      		 
                  max = afwMath.makeStatistics(im, afwMath.MAX).getValue()
      		 
                  if not numpy.isfinite(max):
      		 
                      continue

      This should to be centralized somewhere. I suggest adding this code to meas.algorithms.makePsfCandidate itself (which could delegate some work to a private function, if desired).

        Attachments

          Issue Links

          duplicates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14102 Move makePsfCandidates into its own task

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5680 makePsfCandidate needs to be easier and safer to use

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19155 Redesign PsfCandidate

          • To Do

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-477 Convert makePsfCandidates into its own task

          • Implemented

          Improvement - An improvement or enhancement to an existing feature or task. DM-5532 Change star selectors to return stars instead of PSF candidates

          • Done
          mentioned in

          Page Loading...

          Page Loading...

            Activity

            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm closing this as a duplicate of DM-14102, which seems to have moved this oft-duplicated code block into a new MakePsfCandidateTask.

            Show
            jbosch Jim Bosch added a comment - I'm closing this as a duplicate of DM-14102 , which seems to have moved this oft-duplicated code block into a new MakePsfCandidateTask .

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Jim Bosch, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.