Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5578

making PSF candidates should be simpler

    Details

    • Story Points:
      2

      Description

      The code to make PSF candidates is too complicated and repeated in too many places (even after DM-5532). Every time lsst.meas.algorithms.makePsfCandidate is called (except in a few tests) it is called as follows:

                  cand = measAlg.makePsfCandidate(source, mi)
                  if cand.getWidth() == 0:
                      cand.setBorderWidth(borderWidth)
                      cand.setWidth(kernelSize + 2*borderWidth)
                      cand.setHeight(kernelSize + 2*borderWidth)
       
                  im = cand.getMaskedImage().getImage()
                  max = afwMath.makeStatistics(im, afwMath.MAX).getValue()
                  if not numpy.isfinite(max):
                      continue
      

      This should to be centralized somewhere. I suggest adding this code to meas.algorithms.makePsfCandidate itself (which could delegate some work to a private function, if desired).

        Attachments

          Issue Links

            Activity

            There are no comments yet on this issue.

              People

              • Assignee:
                Unassigned
                Reporter:
                rowen Russell Owen
                Watchers:
                Jim Bosch, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel