Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5588

Add lmfit package to the stack

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsstsw
    • Labels:
      None

      Description

      The current implementation of the new DipoleFitTask for ip_diffim uses lmfit to perform parameter estimation (least-squares minimization). lmfit is essentially an API on top of scipy's optimizer, adding functionality such as parameter boxing (constraints) and improved estimates of parameter uncertainties. It would be nice to include this small, pure-python package in the stack rather than investigating and re-implementing the optimization using scipy or minuit2 (which are the two optimizers that I know of that are in the stack already).

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-168 Add python package lmfit

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            reiss David Reiss added a comment -

            Would you mind reviewing this addition of an lmfit EUPS package?
            I have tested it and it builds and installs on my Mac. (It is pure python so I'm expecting it wouldn't have an issue building on linux as well).
            I also added it to the repos.yaml file in lsstsw (same ticket branch).

            Thank you.

            Show
            reiss David Reiss added a comment - Would you mind reviewing this addition of an lmfit EUPS package? I have tested it and it builds and installs on my Mac. (It is pure python so I'm expecting it wouldn't have an issue building on linux as well). I also added it to the repos.yaml file in lsstsw (same ticket branch). Thank you.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I will review. Please self-merge the `lsstsw` change via a pull request (waiting for the travis validation of the yaml to pass). Then build `lmfit` with Jenkins.

            Show
            tjenness Tim Jenness added a comment - I will review. Please self-merge the `lsstsw` change via a pull request (waiting for the travis validation of the yaml to pass). Then build `lmfit` with Jenkins.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            See http://developer.lsst.io/en/latest/build-ci/new_package.html?highlight=lsstsw for policy on repos.yaml.

            Show
            tjenness Tim Jenness added a comment - See http://developer.lsst.io/en/latest/build-ci/new_package.html?highlight=lsstsw for policy on repos.yaml .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good to me. Feel free to merge once Jenkins passes. Don't forget to tag it properly.

            Show
            tjenness Tim Jenness added a comment - Looks good to me. Feel free to merge once Jenkins passes. Don't forget to tag it properly.
            Hide
            Permalink
            reiss David Reiss added a comment -

            OK, thanks. I merged the lsstsw change and lmfit successfully built on Jenkins (build #9851).

            Show
            reiss David Reiss added a comment - OK, thanks. I merged the lsstsw change and lmfit successfully built on Jenkins (build #9851).

              People

              Assignee:
              reiss David Reiss
              Reporter:
              reiss David Reiss
              Reviewers:
              Tim Jenness
              Watchers:
              David Reiss, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.