Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5634

Add pipe_drivers to lsst_distrib

    Details

      Description

      Please add pipe_drivers to lsst_distrib.

      Does this need an RFC?

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            Like anything else, it needs an RFC if you believe that some affected party might seriously object to your decision and implementation.

            Show
            ktl Kian-Tat Lim added a comment - Like anything else, it needs an RFC if you believe that some affected party might seriously object to your decision and implementation.
            Hide
            swinbank John Swinbank added a comment -

            We agreed at the DRP standup of 31 March that this is unlikely to need an RFC and Paul Price will go ahead with it when DM-5409 is resolved.

            Show
            swinbank John Swinbank added a comment - We agreed at the DRP standup of 31 March that this is unlikely to need an RFC and Paul Price will go ahead with it when DM-5409 is resolved.
            Hide
            price Paul Price added a comment -

            The determination that this was "unlikely to need an RFC" was based on the perception that ctrl_pool was already in lsst_distrib, but it turns out this was wrong. Submitted RFC-171 to include pipe_drivers in lsst_distrib.

            Show
            price Paul Price added a comment - The determination that this was "unlikely to need an RFC" was based on the perception that ctrl_pool was already in lsst_distrib, but it turns out this was wrong. Submitted RFC-171 to include pipe_drivers in lsst_distrib.
            Hide
            price Paul Price added a comment -

            Sorry to bother you again so soon, Tim Jenness, but this is super easy, and I wanted to bother someone with your high-level view to ensure that this is indeed OK to merge.

            price@price-laptop:~/LSST/lsst_distrib (tickets/DM-5634=) $ git sub-patch
            commit fa72bcd6f89136c65b004d79c628bb16d738382e
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon May 9 17:08:39 2016 -0400
             
                add pipe_drivers
             
            diff --git a/ups/lsst_distrib.table b/ups/lsst_distrib.table
            index 9fe0d5a..9e29b60 100644
            --- a/ups/lsst_distrib.table
            +++ b/ups/lsst_distrib.table
            @@ -6,3 +6,4 @@ setupRequired(ctrl_platform_lsst)
             setupRequired(datarel)
             setupOptional(obs_subaru)
             setupOptional(meas_extensions_shapeHSM)
            +setupOptional(pipe_drivers)
            

            Show
            price Paul Price added a comment - Sorry to bother you again so soon, Tim Jenness , but this is super easy, and I wanted to bother someone with your high-level view to ensure that this is indeed OK to merge. price@price-laptop:~/LSST/lsst_distrib (tickets/DM-5634=) $ git sub-patch commit fa72bcd6f89136c65b004d79c628bb16d738382e Author: Paul Price <price@astro.princeton.edu> Date: Mon May 9 17:08:39 2016 -0400   add pipe_drivers   diff --git a/ups/lsst_distrib.table b/ups/lsst_distrib.table index 9fe0d5a..9e29b60 100644 --- a/ups/lsst_distrib.table +++ b/ups/lsst_distrib.table @@ -6,3 +6,4 @@ setupRequired(ctrl_platform_lsst) setupRequired(datarel) setupOptional(obs_subaru) setupOptional(meas_extensions_shapeHSM) +setupOptional(pipe_drivers)
            Hide
            tjenness Tim Jenness added a comment -

            Looks fine as optional given the other optional items in there. I assume there was a Jenkins run of this patch to ensure it all works as we expect? Once closed I think that means the RFC can be changed to Implemented.

            Show
            tjenness Tim Jenness added a comment - Looks fine as optional given the other optional items in there. I assume there was a Jenkins run of this patch to ensure it all works as we expect? Once closed I think that means the RFC can be changed to Implemented.
            Hide
            price Paul Price added a comment -

            Thanks again, Tim Jenness!

            Jenkins passed.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks again, Tim Jenness ! Jenkins passed . Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Tim Jenness
                Watchers:
                Hsin-Fang Chiang, John Swinbank, Kian-Tat Lim, Nate Lust, Paul Price, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: