Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5641

finish up afw.table to astropy.table view support

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      DRP X16-2, DRP X16-3
    • Team:
      Data Release Production

      Description

      At an LSST/AstroPy summit hack session, we've put together a functional system for viewing afw.table objects as astropy.table objects on branch u/jbosch/astropy-tables of afw and https://github.com/astropy/astropy/pull/4740.

      Before merging, we should add support for "object" columns for subclasses to hold e.g. Footprints in SourceCatalog, and add some documentation. We may also want to add a convenience method to return an astropy.table.Table directly.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I'm stealing this back, as I think I can finish it up rapidly now that the Astropy-side interface discussion is converging (it's now at https://github.com/astropy/astropy/pull/4885).

            I'm going to defer object tables for Footprints to a new ticket.

            Show
            jbosch Jim Bosch added a comment - I'm stealing this back, as I think I can finish it up rapidly now that the Astropy-side interface discussion is converging (it's now at https://github.com/astropy/astropy/pull/4885 ). I'm going to defer object tables for Footprints to a new ticket.
            Hide
            tjenness Tim Jenness added a comment -

            Can we make this a blocker on 12.0 release (DM-6057)?

            Show
            tjenness Tim Jenness added a comment - Can we make this a blocker on 12.0 release ( DM-6057 )?
            Hide
            jbosch Jim Bosch added a comment -

            Ready for review. Tim Jenness, could you take a look? More info on the PR and in the commit messages.

            Show
            jbosch Jim Bosch added a comment - Ready for review. Tim Jenness , could you take a look? More info on the PR and in the commit messages.
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me. Excellent test coverage. I'd grumble about the name but it's fine.

            Show
            tjenness Tim Jenness added a comment - Looks good to me. Excellent test coverage. I'd grumble about the name but it's fine.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Tim Jenness
                Watchers:
                Jim Bosch, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel