Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5642

use AstroPy-compliant strings for units in afw.table

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, meas_base
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      DRP X16-2, DRP X16-3
    • Team:
      Data Release Production

      Description

      With DM-5641, we'll soon be able to get astropy.table views into afw.table objects. That will be a bit more useful if astropy can understand the unit strings we give it, and since we currently don't use those strings as anything more than textual information for humans, we might as well standardize on the terms they've already selected.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            The requested changes have been implemented (including the addition of checkUnits()). This caught many more cases of incorrect units which have now also been fixed. As a result the list of packages affected has grown substantially. Jim Bosch, please check if all changes are satisfactory.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - The requested changes have been implemented (including the addition of checkUnits() ). This caught many more cases of incorrect units which have now also been fixed. As a result the list of packages affected has grown substantially. Jim Bosch , please check if all changes are satisfactory.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Note that CI (including ci_hsc) has completed successfully.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Note that CI (including ci_hsc) has completed successfully.
            Hide
            jbosch Jim Bosch added a comment -

            Looks fine to me. Tim Jenness made a good point about perhaps providing a bit more detail in the git commit message when the changes involve FITS headers, but if that's too hard to reproduce I'm not sure it's necessary; having looked a bit at the FITS files in question, I think the changes are sufficiently trivial that it's not too big a deal if we don't record them in detail.

            Show
            jbosch Jim Bosch added a comment - Looks fine to me. Tim Jenness made a good point about perhaps providing a bit more detail in the git commit message when the changes involve FITS headers, but if that's too hard to reproduce I'm not sure it's necessary; having looked a bit at the FITS files in question, I think the changes are sufficiently trivial that it's not too big a deal if we don't record them in detail.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            I can easily rebase and reword when fits files were modified. But specifically mentioning which units were changed where would require a lot of work. I can however put the full list of possible replacements in. Although that might also be confusing.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - I can easily rebase and reword when fits files were modified. But specifically mentioning which units were changed where would require a lot of work. I can however put the full list of possible replacements in. Although that might also be confusing.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merge complete.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merge complete.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: