Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5655

Reduce code duplication in StarSelectors

    XMLWordPrintable

    Details

    • Story Points:
      2

      Description

      Both ObjectSizeStarSelector and SecondMomentStarSelector have logic to transform measured moments from pixel coordinates to TAN_PIXELS in order to remove optical distortion. That's generically useful for any star selector that works on measured moments, and we shouldn't have to repeat it everywhere it is used.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-5532 Change star selectors to return stars instead of PSF candidates

          • Done
          mentioned in

          Page Loading...

            Activity

            Hide
            Permalink
            swinbank John Swinbank added a comment -

            SecondMomentStarSelector was removed on RFC-475 / DM-14233 on the basis that it was fully replaced by ObjectSizeStarSelector. While the latter still contains the code in question, I don't see it repeated anywhere else (at least not in meas_algorithms), so I think we can close this.

            Show
            swinbank John Swinbank added a comment - SecondMomentStarSelector was removed on RFC-475 / DM-14233 on the basis that it was fully replaced by ObjectSizeStarSelector . While the latter still contains the code in question, I don't see it repeated anywhere else (at least not in meas_algorithms), so I think we can close this.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.