Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5663

Config override fixes needed due to new star selector

    XMLWordPrintable

Details

    Description

      As of DM-5532 a few config files need updating to not refer to star selector config fields as registries (not ones run by our normal CI, which is how I missed this).

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment -

            price does it again! I'll restore the try/except around everything and hope for DM-5680 to make this code better later.

            rowen Russell Owen added a comment - price does it again! I'll restore the try/except around everything and hope for DM-5680 to make this code better later.
            price Paul Price added a comment -

            Looks good to me.

            You might want to add a comment (either in the code or commit message) about where the exception is coming from.

            price Paul Price added a comment - Looks good to me. You might want to add a comment (either in the code or commit message) about where the exception is coming from.
            rowen Russell Owen added a comment -

            price I made quite a few cleanups in meas_extensions_psfex after your review, as the library file utils.py had a large number of errors and linter warnings and I felt the imports in all the library code could be cleaner. Do you want to take another look or shall I just merge? The code now passes ci_hsc. I'm sorry I didn't wait until it all built to ask you to review the first time.

            rowen Russell Owen added a comment - price I made quite a few cleanups in meas_extensions_psfex after your review, as the library file utils.py had a large number of errors and linter warnings and I felt the imports in all the library code could be cleaner. Do you want to take another look or shall I just merge? The code now passes ci_hsc . I'm sorry I didn't wait until it all built to ask you to review the first time.
            rowen Russell Owen added a comment -

            price one question about your review: what exception are you referring to? The one being raised by StarSelectorTask.makePsfCandidates?

            rowen Russell Owen added a comment - price one question about your review: what exception are you referring to? The one being raised by StarSelectorTask.makePsfCandidates ?
            price Paul Price added a comment -

            I made some small stylistic comments about the meas_extensions_psfex changes on github; nothing major.

            The exception I was referring to is the one coming from makePsfCandidates, but if there are others you're aware of, it might be good to mention those too.

            price Paul Price added a comment - I made some small stylistic comments about the meas_extensions_psfex changes on github; nothing major. The exception I was referring to is the one coming from makePsfCandidates , but if there are others you're aware of, it might be good to mention those too.

            People

              rowen Russell Owen
              rowen Russell Owen
              Paul Price
              Kian-Tat Lim, Paul Price, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.