Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5663

Config override fixes needed due to new star selector

    Details

      Description

      As of DM-5532 a few config files need updating to not refer to star selector config fields as registries (not ones run by our normal CI, which is how I missed this).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Paul Price does it again! I'll restore the try/except around everything and hope for DM-5680 to make this code better later.

            Show
            rowen Russell Owen added a comment - Paul Price does it again! I'll restore the try/except around everything and hope for DM-5680 to make this code better later.
            Hide
            price Paul Price added a comment -

            Looks good to me.

            You might want to add a comment (either in the code or commit message) about where the exception is coming from.

            Show
            price Paul Price added a comment - Looks good to me. You might want to add a comment (either in the code or commit message) about where the exception is coming from.
            Hide
            rowen Russell Owen added a comment -

            Paul Price I made quite a few cleanups in meas_extensions_psfex after your review, as the library file utils.py had a large number of errors and linter warnings and I felt the imports in all the library code could be cleaner. Do you want to take another look or shall I just merge? The code now passes ci_hsc. I'm sorry I didn't wait until it all built to ask you to review the first time.

            Show
            rowen Russell Owen added a comment - Paul Price I made quite a few cleanups in meas_extensions_psfex after your review, as the library file utils.py had a large number of errors and linter warnings and I felt the imports in all the library code could be cleaner. Do you want to take another look or shall I just merge? The code now passes ci_hsc . I'm sorry I didn't wait until it all built to ask you to review the first time.
            Hide
            rowen Russell Owen added a comment -

            Paul Price one question about your review: what exception are you referring to? The one being raised by StarSelectorTask.makePsfCandidates?

            Show
            rowen Russell Owen added a comment - Paul Price one question about your review: what exception are you referring to? The one being raised by StarSelectorTask.makePsfCandidates ?
            Hide
            price Paul Price added a comment -

            I made some small stylistic comments about the meas_extensions_psfex changes on github; nothing major.

            The exception I was referring to is the one coming from makePsfCandidates, but if there are others you're aware of, it might be good to mention those too.

            Show
            price Paul Price added a comment - I made some small stylistic comments about the meas_extensions_psfex changes on github; nothing major. The exception I was referring to is the one coming from makePsfCandidates , but if there are others you're aware of, it might be good to mention those too.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Paul Price
                Watchers:
                Kian-Tat Lim, Paul Price, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel