Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5684

Unused variables in meas_extensions_psfex library code

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F20-5 (October), AP F20-6 (November)
    • Team:
      Alert Production

      Description

      meas_extensions_psfex library code contains many errors and warnings. Much of this will be fixed in DM-5663, but some fixes are less obvious. Those should be done on this ticket. Errors include undefined variable vignet in psfexStarSelector.py, several others in psfexPsfDeterminer and many in utils.py

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-5304 Use psfex as the default PSF determiner

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10163 Create tests to probe Psfex bugs

          • Invalid
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-4905 PsfexStarSelector uses an undefined variable

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-9980 PsfexPsfDeterminerTask.determinePsf uses undefined variables

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3441 Clean up and document PSFEx

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5663 Config override fixes needed due to new star selector

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6474 Restore star selector registry

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Because the code to use maxbadflag is broken (the undefined vignet variable), we should just deprecate it so we can remove it.

            Show
            Parejkoj John Parejko added a comment - Because the code to use maxbadflag is broken (the undefined vignet variable), we should just deprecate it so we can remove it.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Similarly for the other errors: given the impending arrival of PIFF, we should just ensure that these errors are trapped for, relevant code is deprecated, and/or removed.

            Show
            Parejkoj John Parejko added a comment - Similarly for the other errors: given the impending arrival of PIFF, we should just ensure that these errors are trapped for, relevant code is deprecated, and/or removed.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32909/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32909/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Gabor Kovacs [X]: do you mind this small-ish review? It's mostly deletions, with a handful of fixes.

            I recommend doing it by commit: the commits should all be atomic and should each make sense in context.

            Show
            Parejkoj John Parejko added a comment - Gabor Kovacs [X] : do you mind this small-ish review? It's mostly deletions, with a handful of fixes. I recommend doing it by commit: the commits should all be atomic and should each make sense in context.
            Hide
            Permalink
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            There was a lot to clean up here! Please see my minor comments on GitHub.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - There was a lot to clean up here! Please see my minor comments on GitHub.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the comments: I incorporated some, but left the others in place as I don't want to dig into some of those changes in existing code.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the comments: I incorporated some, but left the others in place as I don't want to dig into some of those changes in existing code. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              rowen Russell Owen
              Reviewers:
              Gabor Kovacs [X] (Inactive)
              Watchers:
              Gabor Kovacs [X] (Inactive), John Parejko, Nate Lust, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.