Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5718

Reduce verbosity of WCS fitter

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None
    • Story Points:
      0.1
    • Sprint:
      DRP X16-2
    • Team:
      Data Release Production

      Description

      The WCS fitter is too chatty:

      processCcd.calibrate.astrometry.matcher: filterStars purged 0 reference stars, leaving 85 stars
      processCcd.calibrate.astrometry.matcher: Purged 1314 unusable sources, leaving 40 usable sources
      processCcd.calibrate.astrometry.matcher: Matched 23 sources
      processCcd.calibrate.astrometry.wcsFitter: Updating centroids in refCat
      processCcd.calibrate.astrometry.wcsFitter: Updating coords in sourceCat
      processCcd.calibrate.astrometry.wcsFitter: Updating distance in match list
      processCcd.calibrate.astrometry.matcher: filterStars purged 0 reference stars, leaving 85 stars
      processCcd.calibrate.astrometry.matcher: Purged 1314 unusable sources, leaving 40 usable sources
      processCcd.calibrate.astrometry.matcher: Matched 22 sources
      processCcd.calibrate.astrometry.wcsFitter: Updating centroids in refCat
      processCcd.calibrate.astrometry.wcsFitter: Updating coords in sourceCat
      processCcd.calibrate.astrometry.wcsFitter: Updating distance in match list
      processCcd.calibrate.astrometry.matcher: filterStars purged 0 reference stars, leaving 85 stars
      processCcd.calibrate.astrometry.matcher: Purged 1314 unusable sources, leaving 40 usable sources
      processCcd.calibrate.astrometry.matcher: Matched 21 sources
      processCcd.calibrate.astrometry.wcsFitter: Updating centroids in refCat
      processCcd.calibrate.astrometry.wcsFitter: Updating coords in sourceCat
      processCcd.calibrate.astrometry.wcsFitter: Updating distance in match list
      

      The "Updating" messages don't provide any useful information for the user, and only clutter the logs.

        Attachments

          Activity

          Hide
          price Paul Price added a comment - - edited

          This has passed Jenkins. The patch is straight-forward:

          price@price-laptop:~/LSST/meas/astrom (tickets/DM-5718=) $ git sub-patch
          commit 2eb273b741d9b460b9bebcfd566cbd86ac8ae0fd
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Tue Apr 5 12:22:46 2016 -0400
           
              reduce verbosity of WCS fitter
              
              The "Updating" messages don't provide any useful information for the
              user, and only clutter the logs so move them to "debug" level.
           
          diff --git a/python/lsst/meas/astrom/fitTanSipWcs.py b/python/lsst/meas/astrom/fitTanSipWcs.py
          index 326ff16..3133de2 100644
          --- a/python/lsst/meas/astrom/fitTanSipWcs.py
          +++ b/python/lsst/meas/astrom/fitTanSipWcs.py
          @@ -153,20 +153,20 @@ class FitTanSipWcsTask(pipeBase.Task):
                       self.plotFit(matches, wcs, rejected)
           
                   if refCat is not None:
          -            self.log.info("Updating centroids in refCat")
          +            self.log.logdebug("Updating centroids in refCat")
                       self.updateRefCentroids(wcs, refList=refCat)
                   else:
                       self.log.warning("Updating reference object centroids in match list; refCat is None")
                       self.updateRefCentroids(wcs, refList=[match.first for match in matches])
           
                   if sourceCat is not None:
          -            self.log.info("Updating coords in sourceCat")
          +            self.log.logdebug("Updating coords in sourceCat")
                       self.updateSourceCoords(wcs, sourceList=sourceCat)
                   else:
                       self.log.warning("Updating source coords in match list; sourceCat is None")
                       self.updateSourceCoords(wcs, sourceList=[match.second for match in matches])
           
          -        self.log.info("Updating distance in match list")
          +        self.log.logdebug("Updating distance in match list")
                   setMatchDistance(matches)
           
                   scatterOnSky = sipObject.getScatterOnSky()
          

          Show
          price Paul Price added a comment - - edited This has passed Jenkins . The patch is straight-forward: price@price-laptop:~/LSST/meas/astrom (tickets/DM-5718=) $ git sub-patch commit 2eb273b741d9b460b9bebcfd566cbd86ac8ae0fd Author: Paul Price <price@astro.princeton.edu> Date: Tue Apr 5 12:22:46 2016 -0400   reduce verbosity of WCS fitter The "Updating" messages don't provide any useful information for the user, and only clutter the logs so move them to "debug" level.   diff --git a/python/lsst/meas/astrom/fitTanSipWcs.py b/python/lsst/meas/astrom/fitTanSipWcs.py index 326ff16..3133de2 100644 --- a/python/lsst/meas/astrom/fitTanSipWcs.py +++ b/python/lsst/meas/astrom/fitTanSipWcs.py @@ -153,20 +153,20 @@ class FitTanSipWcsTask(pipeBase.Task): self.plotFit(matches, wcs, rejected) if refCat is not None: - self.log.info("Updating centroids in refCat") + self.log.logdebug("Updating centroids in refCat") self.updateRefCentroids(wcs, refList=refCat) else: self.log.warning("Updating reference object centroids in match list; refCat is None") self.updateRefCentroids(wcs, refList=[match.first for match in matches]) if sourceCat is not None: - self.log.info("Updating coords in sourceCat") + self.log.logdebug("Updating coords in sourceCat") self.updateSourceCoords(wcs, sourceList=sourceCat) else: self.log.warning("Updating source coords in match list; sourceCat is None") self.updateSourceCoords(wcs, sourceList=[match.second for match in matches]) - self.log.info("Updating distance in match list") + self.log.logdebug("Updating distance in match list") setMatchDistance(matches) scatterOnSky = sipObject.getScatterOnSky()
          Hide
          rowen Russell Owen added a comment -

          Seems like a good change. Thanks for doing this.

          Show
          rowen Russell Owen added a comment - Seems like a good change. Thanks for doing this.
          Hide
          price Paul Price added a comment -

          Thanks, Russell Owen.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks, Russell Owen . Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Russell Owen
              Watchers:
              Paul Price, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel