Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5748

Upgrade mpi4py to latest upstream

    Details

    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      mpi4py version 2.0 was released in October 2015 with a number of changes. We should upgrade. When upgrading, we should check whether it contains a proper fix for DM-5409 and, if not, file a bug report upstream.

      This issue should not be addressed until we have proper test coverage on code which uses mpi4py (DM-3845).

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            All of the mpi4py tests pass on OS X using the newest mpich, which can be installed from binary (with the setupRequired line removed from lsst.mpi). Jenkins does not run the mpi4py tests, so there is no real way to test the package other than that it passes the build.

            Show
            fred3m Fred Moolekamp added a comment - All of the mpi4py tests pass on OS X using the newest mpich, which can be installed from binary (with the setupRequired line removed from lsst.mpi). Jenkins does not run the mpi4py tests, so there is no real way to test the package other than that it passes the build.
            Hide
            fred3m Fred Moolekamp added a comment -

            Hi John,
            Tim took ctrl_pool, would you mind reviewing mpi4py for me?

            Thanks,
            -Fred

            Show
            fred3m Fred Moolekamp added a comment - Hi John, Tim took ctrl_pool, would you mind reviewing mpi4py for me? Thanks, -Fred
            Hide
            swinbank John Swinbank added a comment -

            Can you say more about the patch you've removed? Without more context (or thinking), I'm not sure what it was supposed to achieve; I'm not sure if you've removed it because it was unnecessary, because it's obsoleted by mpi4py 2.0, or just because you don't understand it any more than I do.

            Whatever the reason, I think we should describe it in the commit message. Other than that, good to go. Please remember to tag after merging.

            Show
            swinbank John Swinbank added a comment - Can you say more about the patch you've removed? Without more context (or thinking), I'm not sure what it was supposed to achieve; I'm not sure if you've removed it because it was unnecessary, because it's obsoleted by mpi4py 2.0, or just because you don't understand it any more than I do. Whatever the reason, I think we should describe it in the commit message. Other than that, good to go. Please remember to tag after merging.
            Hide
            fred3m Fred Moolekamp added a comment -

            It looks like the patch was needed because mpi4py has a demo using fortran and the patch is necessary to install mpi4py without a fortran compiler. I created a new patch and successfully tested it on my system and on Jenkins.

            Show
            fred3m Fred Moolekamp added a comment - It looks like the patch was needed because mpi4py has a demo using fortran and the patch is necessary to install mpi4py without a fortran compiler. I created a new patch and successfully tested it on my system and on Jenkins.
            Hide
            fred3m Fred Moolekamp added a comment -

            I modified the patch to allow mpi4py to build without a fortran compiler, retested the mpi4py tests on my local machine, and the ctrl_pool demo.

            Branch has been merged.

            Show
            fred3m Fred Moolekamp added a comment - I modified the patch to allow mpi4py to build without a fortran compiler, retested the mpi4py tests on my local machine, and the ctrl_pool demo. Branch has been merged.

              People

              • Assignee:
                fred3m Fred Moolekamp
                Reporter:
                swinbank John Swinbank
                Reviewers:
                John Swinbank
                Watchers:
                Fred Moolekamp, John Swinbank, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel