Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5786

CCD ID and CCD name mixed up

    XMLWordPrintable

    Details

      Description

      I think there is a bug in /Users/azuri/lsstsw/stack/DarwinX86/daf_butlerUtils/2016_01.0-4-g325729a+1/python/lsst/daf/butlerUtils/cameraMapper.py(858)_defectLookup():

      ccdKey, ccdVal = self._getCcdKeyVal(dataId)
      

      which assigns the CCD name (in my case 'r_2') to ccdVal, while obs_subaru/bin.src/genDefectFits.py and obs_subaru/bin.src/genDefectRegistry.py use the ccd ID (in my case '5') or serial number (5) to create the fits file containing the defects for each CCD. For HSC, the CCD name, ID, and serial are all the same, but it's causing trouble for PFS...

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            We discussed this at the 2016-05-23 meeting.

            Broadly, we aren't convinced if there's really an issue here and, if there is, it seems like it might be more conveniently addressed by reconsidering the PFS naming convention, as Paul suggested above, rather than by changing the code. For that reason, I don't think we can hold up the LSST sprint waiting for a resolution of that.

            We were tempting to close as "Won't Fix", but I want to make sure that Andreas/PFS are happy, and I want to better understand what's going on here myself. For that reason, I'm reassigning to me and am dropping from the current sprint & cycle. Andreas, it's unlikely we'll be able to dedicate any significant LSST time to this in the next ~month, but let's sync up during some of my PFS time and make sure we're on the same page.

            Show
            swinbank John Swinbank added a comment - We discussed this at the 2016-05-23 meeting. Broadly, we aren't convinced if there's really an issue here and, if there is, it seems like it might be more conveniently addressed by reconsidering the PFS naming convention, as Paul suggested above, rather than by changing the code. For that reason, I don't think we can hold up the LSST sprint waiting for a resolution of that. We were tempting to close as "Won't Fix", but I want to make sure that Andreas/PFS are happy, and I want to better understand what's going on here myself. For that reason, I'm reassigning to me and am dropping from the current sprint & cycle. Andreas, it's unlikely we'll be able to dedicate any significant LSST time to this in the next ~month, but let's sync up during some of my PFS time and make sure we're on the same page.
            Hide
            nlust Nate Lust added a comment -

            What is the status of this ticket? I would like to get it out of my review queue if possible. Are we any closer to closing it?

            Show
            nlust Nate Lust added a comment - What is the status of this ticket? I would like to get it out of my review queue if possible. Are we any closer to closing it?
            Hide
            swinbank John Swinbank added a comment -

            [It's no longer in review, but it's no closer to being closed.]

            Show
            swinbank John Swinbank added a comment - [It's no longer in review, but it's no closer to being closed.]
            Hide
            tjenness Tim Jenness added a comment -

            Since defects handling in obs_subaru was rewritten in DM-18739, does that mean this ticket is no longer relevant?

            Show
            tjenness Tim Jenness added a comment - Since defects handling in obs_subaru was rewritten in DM-18739 , does that mean this ticket is no longer relevant?
            Hide
            swinbank John Swinbank added a comment -

            Since Andreas has left the project and the current PFS team don't report problems, I think we can close this.

            Show
            swinbank John Swinbank added a comment - Since Andreas has left the project and the current PFS team don't report problems, I think we can close this.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              aritter Andreas Ritter
              Watchers:
              Andreas Ritter, John Swinbank, Nate Lust, Paul Price, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.