Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5798

Pass butler to ref loader

    Details

    • Story Points:
      4
    • Sprint:
      Alert Production X16 - 04, Alert Production X16 - 5
    • Team:
      Alert Production

      Description

      The design of the indexed reference catalogs requires a butler to be sent to the loader. This requires passing the butler down through the chain of subtasks from the parent command line task. In this case, I believe only calibrateTask constructs sub-tasks that requires a reference catalog.

      This will also require moving the loader and indexer to meas_astrom, otherwise it will introduce a circular dependency.

        Attachments

          Activity

          Hide
          krughoff Simon Krughoff added a comment -

          This passed jenkins.

          Show
          krughoff Simon Krughoff added a comment - This passed jenkins.
          Hide
          rowen Russell Owen added a comment -

          Overall this looks excellent.

          My main suggestion is to make butler an explicit argument for the calibrate and image char tasks (as per detailed comments in github).

          Also, please file a ticket to change the existing examples and unit tests to use your new ref object loader instead of the a.net loader (and link it to the existing ticket of separating astrometry.net from meas_astrom).

          Show
          rowen Russell Owen added a comment - Overall this looks excellent. My main suggestion is to make butler an explicit argument for the calibrate and image char tasks (as per detailed comments in github). Also, please file a ticket to change the existing examples and unit tests to use your new ref object loader instead of the a.net loader (and link it to the existing ticket of separating astrometry.net from meas_astrom).
          Hide
          krughoff Simon Krughoff added a comment -

          Merging.

          Show
          krughoff Simon Krughoff added a comment - Merging.

            People

            • Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Simon Krughoff
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: