Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5801

Audit and update SdssShape

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      The SdssShape contains a number of poorly-motivated numerical constants ("magic numbers", e.g. here) and inconsistent sanity checks (compare here and here).

      Please audit the code for these issues. In particular:

      • Check for numerical constants and ensure their values are appropriate and properly justified.
      • Ensure that checks on the shape determinant are consistent, including both those listed above and those added in DM-3935.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            It seems unlikely that we will ever work this ticket as described; rather, we will continue to address bugs and emergent issues in SdssShape when they are identified.

            Show
            swinbank John Swinbank added a comment - It seems unlikely that we will ever work this ticket as described; rather, we will continue to address bugs and emergent issues in SdssShape when they are identified.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Watchers:
              Jim Bosch, John Swinbank, Lauren MacArthur, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: