Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5870

Update testdata_subaru to support calib changes

    Details

    • Story Points:
      0.5
    • Sprint:
      DRP X16-2
    • Team:
      Data Release Production

      Description

      Merging DM-5124 broke obs_subaru because the test data in testdata_subaru wasn't updated. Fix it.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            No changes to code. Empty *_visit tables in the registry don't seem to be necessary but do no harm. I didn't review the data file contents.

            Show
            ktl Kian-Tat Lim added a comment - No changes to code. Empty *_visit tables in the registry don't seem to be necessary but do no harm. I didn't review the data file contents.
            Hide
            price Paul Price added a comment -

            You beat me to asking you!

            This appears to have fixed things. Jenkins says:

                      obs_subaru: 5.0.0.1-85-ge5344d8+1 .............................ok (100.6 sec).
            

            There's a single commit on testdata_subaru. You may not want to download the 90 MB of data (via git-lfs), and just inspect the commit summary:

            pprice@tiger-sumire:~/LSST/testdata/subaru (tickets/DM-5870=) $ git sub
            commit 92b0a6d907bd5dbb7f90a620ee8fe46b1521120c
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Tue Apr 26 20:28:58 2016 -0400
             
                update calibs following rename and rotation removal
                
                In DM-5124 we removed rotation (due to the old cameraGeom) and changed
                the naming scheme. This requires new calibs, which are provided here
                from the calibs constructed as part of that ticket.
             
             hsc/calib/BIAS/2013-11-02/NONE/master/BIAS-050.fits.gz            | 3 ---
             hsc/calib/BIAS/2013-11-03/NONE/BIAS-2013-11-03-050.fits.gz        | 3 +++
             hsc/calib/DARK/2013-11-01/NONE/master/DARK-050.fits.gz            | 3 ---
             hsc/calib/DARK/2013-11-03/NONE/DARK-2013-11-03-050.fits.gz        | 3 +++
             hsc/calib/FLAT/2013-11-03/HSC-I/FLAT-2013-11-03-HSC-I-050.fits.gz | 3 +++
             hsc/calib/FLAT/2013-11-04/HSC-I/dome/FLAT-050.fits.gz             | 3 ---
             hsc/calib/calibRegistry.sqlite3                                   | 4 ++--
             7 files changed, 11 insertions(+), 11 deletions(-)
            

            Show
            price Paul Price added a comment - You beat me to asking you! This appears to have fixed things. Jenkins says: obs_subaru: 5.0.0.1-85-ge5344d8+1 .............................ok (100.6 sec). There's a single commit on testdata_subaru. You may not want to download the 90 MB of data (via git-lfs), and just inspect the commit summary: pprice@tiger-sumire:~/LSST/testdata/subaru (tickets/DM-5870=) $ git sub commit 92b0a6d907bd5dbb7f90a620ee8fe46b1521120c Author: Paul Price <price@astro.princeton.edu> Date: Tue Apr 26 20:28:58 2016 -0400   update calibs following rename and rotation removal In DM-5124 we removed rotation (due to the old cameraGeom) and changed the naming scheme. This requires new calibs, which are provided here from the calibs constructed as part of that ticket.   hsc/calib/BIAS/2013-11-02/NONE/master/BIAS-050.fits.gz | 3 --- hsc/calib/BIAS/2013-11-03/NONE/BIAS-2013-11-03-050.fits.gz | 3 +++ hsc/calib/DARK/2013-11-01/NONE/master/DARK-050.fits.gz | 3 --- hsc/calib/DARK/2013-11-03/NONE/DARK-2013-11-03-050.fits.gz | 3 +++ hsc/calib/FLAT/2013-11-03/HSC-I/FLAT-2013-11-03-HSC-I-050.fits.gz | 3 +++ hsc/calib/FLAT/2013-11-04/HSC-I/dome/FLAT-050.fits.gz | 3 --- hsc/calib/calibRegistry.sqlite3 | 4 ++-- 7 files changed, 11 insertions(+), 11 deletions(-)
            Hide
            price Paul Price added a comment -

            Merged to master.

            Thanks for the super-quick review, Kian-Tat Lim!

            Show
            price Paul Price added a comment - Merged to master. Thanks for the super-quick review, Kian-Tat Lim !

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Watchers:
                Kian-Tat Lim, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel