Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5877

Use Afterburners to clean up aperture correction logic

    Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Templates:
    • Story Points:
      6
    • Sprint:
      DRP X16-3, DRP F16-1, DRP F16-2
    • Team:
      Data Release Production

      Description

      This issue has several components; I'm combining them into a single issue because they need to be done atomically:

      • Rewrite the base_ClassificationExtendedness SingleFramePlugin/ForcedPlugin as an AfterburnerPlugin (and remove the old versions).
      • Move the "applyApCorr" subtask out of SingleFrameMeasurementTask and ForcedMeasurementTask, making it instead a subclass of their parent Tasks.
      • Add afterburner subtask stages to ProcessCcdTask (within DetectAndMeasureTask) and the multiband tasks wherever measurement is currently being run. The afterburner tasks should be run after aperture corrections are measured and/or applied.

      After these changes, throughout the stack, whenever a MeasurementTask is run, we also run ApplyApCorrTask and AfterburnerTask (in that order), while possibly running MeasureApCorrTask immediately after the MeasurementTask.

      This may or may not enable significant cleanups in DetectAndMeasureTask (I haven't looked closely). If so, they should be done on this issue.

      Given all the moving parts, it's important to check that the actual behavior of the pipeline (in the aperture correction and extendedness values) does not change, so it might be useful to start by creating some reference outputs to compare against.

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  nlust Nate Lust
                  Reporter:
                  jbosch Jim Bosch
                  Reviewers:
                  Paul Price
                  Watchers:
                  Jim Bosch, Nate Lust, Paul Price, Russell Owen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel