XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
1
• Team:
Data Facility

## Description

obs_decam originally included 'object' and 'proposal' fields in the registry but these were removed at some point. Putting them back would allow users to more easily select data.

## Activity

Hide
Merlin Fisher-Levine added a comment - - edited

Path to 'sky' DECam raw fits file, as requested: (on lsst-dev)

/nfs/lsst2/photocalData/data/observer2/DECam_00496473.fits.fz

Show
Merlin Fisher-Levine added a comment - - edited Path to 'sky' DECam raw fits file, as requested: (on lsst-dev) /nfs/lsst2/photocalData/data/observer2/DECam_00496473.fits.fz
Hide
Hsin-Fang Chiang added a comment -
Show
Hsin-Fang Chiang added a comment - For reference what 'object' and 'proposal' fields used to mean: https://github.com/lsst/obs_decam/commit/ea942a460ce60c2e50552a8692cb14413d4c43ae and the old templates: https://github.com/lsst/obs_decam/commit/567773bd189a325771e41eefa4e990f806dd1a12
Hide
Hsin-Fang Chiang added a comment -

Merlin Fisher-Levine may you please review this and try if it works for you? obs_decam should be the only ticket branch you need, and please use it with stack w_2017_13.

The "hack" of adding the object key is still added in DecamMapper; I leave it for DM-5902 to fix.

The ticket branch of testdata_decam got merged into master by accident in DM-5466, but it should not affect much.

Show
Hsin-Fang Chiang added a comment - Merlin Fisher-Levine may you please review this and try if it works for you? obs_decam should be the only ticket branch you need, and please use it with stack w_2017_13 . The "hack" of adding the object key is still added in DecamMapper; I leave it for DM-5902 to fix. PR here: https://github.com/lsst/obs_decam/pull/53 The ticket branch of testdata_decam got merged into master by accident in DM-5466 , but it should not affect much.
Hide
Merlin Fisher-Levine added a comment -

Sure, but could I ask for an extension please? I will certainly be able to get to this by or on Wednesday, is that OK? Or do you need it done sooner than that?

Show
Merlin Fisher-Levine added a comment - Sure, but could I ask for an extension please? I will certainly be able to get to this by or on Wednesday, is that OK? Or do you need it done sooner than that?
Hide
Hsin-Fang Chiang added a comment -

Merlin Fisher-Levine that's fine. Thank you!

Show
Hsin-Fang Chiang added a comment - Merlin Fisher-Levine that's fine. Thank you!
Hide
Merlin Fisher-Levine added a comment -

This looks good and works. Feel free to merge.

Show
Merlin Fisher-Levine added a comment - This looks good and works. Feel free to merge.
Hide
Hsin-Fang Chiang added a comment -

Thank you Merlin Fisher-Levine for reviewing and testing. Merged to master.

For future reference, the DM-5902 workaround was added only for using raw with the object key. It can be used in Merlin's example such as:

 constructBias.py repo/root --id object='DomeFlat-g40' ..... 

The workaround is not added for the proposal key but DM-5902 will solve that. Before it's
solve, an error like below is expected when running CmdLineTasks with --id proposal=abc

 error: "Unrecognized ID key 'proposal'; valid keys are: ['ccdnum', u'date', u'filter', u'hdu', 'object', u'visit']" 

Merlin Fisher-Levine has an idea of writing a translate method which, for example, allows --id object='DomeFlat' to select any file with DomeFlat-* in its OBJECT header. I leave that to his future ticket.

Show
Hsin-Fang Chiang added a comment - Thank you Merlin Fisher-Levine for reviewing and testing. Merged to master. For future reference, the DM-5902 workaround was added only for using raw with the object key. It can be used in Merlin's example such as: constructBias.py repo/root --id object= 'DomeFlat-g40' ..... The workaround is not added for the proposal key but DM-5902 will solve that. Before it's solve, an error like below is expected when running CmdLineTasks with --id proposal=abc error: "Unrecognized ID key 'proposal'; valid keys are: ['ccdnum', u'date', u'filter', u'hdu', 'object', u'visit']" Merlin Fisher-Levine has an idea of writing a translate method which, for example, allows --id object='DomeFlat' to select any file with DomeFlat-* in its OBJECT header. I leave that to his future ticket.
Hide
Merlin Fisher-Levine added a comment -

See DM-10198 for the ticket requesting support for globs in data selection.

Show
Merlin Fisher-Levine added a comment - See DM-10198 for the ticket requesting support for globs in data selection.

## People

• Assignee:
Hsin-Fang Chiang
Reporter:
Paul Price
Reviewers:
Merlin Fisher-Levine
Watchers:
Colin Slater, Hsin-Fang Chiang, Merlin Fisher-Levine, Paul Price