Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5883

Include more information in DECam registry

    Details

      Description

      obs_decam originally included 'object' and 'proposal' fields in the registry but these were removed at some point. Putting them back would allow users to more easily select data.

      I also suggest surveying the headers for additional useful fields.

        Attachments

          Issue Links

            Activity

            Hide
            mfisherlevine Merlin Fisher-Levine added a comment - - edited

            Path to 'sky' DECam raw fits file, as requested: (on lsst-dev)

            /nfs/lsst2/photocalData/data/observer2/DECam_00496473.fits.fz

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - - edited Path to 'sky' DECam raw fits file, as requested: (on lsst-dev) /nfs/lsst2/photocalData/data/observer2/DECam_00496473.fits.fz
            Show
            hchiang2 Hsin-Fang Chiang added a comment - For reference what 'object' and 'proposal' fields used to mean: https://github.com/lsst/obs_decam/commit/ea942a460ce60c2e50552a8692cb14413d4c43ae and the old templates: https://github.com/lsst/obs_decam/commit/567773bd189a325771e41eefa4e990f806dd1a12
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Merlin Fisher-Levine may you please review this and try if it works for you? obs_decam should be the only ticket branch you need, and please use it with stack w_2017_13.

            The "hack" of adding the object key is still added in DecamMapper; I leave it for DM-5902 to fix.

            PR here: https://github.com/lsst/obs_decam/pull/53

            The ticket branch of testdata_decam got merged into master by accident in DM-5466, but it should not affect much.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Merlin Fisher-Levine may you please review this and try if it works for you? obs_decam should be the only ticket branch you need, and please use it with stack w_2017_13 . The "hack" of adding the object key is still added in DecamMapper; I leave it for DM-5902 to fix. PR here: https://github.com/lsst/obs_decam/pull/53 The ticket branch of testdata_decam got merged into master by accident in DM-5466 , but it should not affect much.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Sure, but could I ask for an extension please? I will certainly be able to get to this by or on Wednesday, is that OK? Or do you need it done sooner than that?

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Sure, but could I ask for an extension please? I will certainly be able to get to this by or on Wednesday, is that OK? Or do you need it done sooner than that?
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Merlin Fisher-Levine that's fine. Thank you!

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Merlin Fisher-Levine that's fine. Thank you!
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            This looks good and works. Feel free to merge.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - This looks good and works. Feel free to merge.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Thank you Merlin Fisher-Levine for reviewing and testing. Merged to master.

            For future reference, the DM-5902 workaround was added only for using raw with the object key. It can be used in Merlin's example such as:

            constructBias.py repo/root --id object='DomeFlat-g40' ..... 
            

            The workaround is not added for the proposal key but DM-5902 will solve that. Before it's
            solve, an error like below is expected when running CmdLineTasks with --id proposal=abc

            error: "Unrecognized ID key 'proposal'; valid keys are: ['ccdnum', u'date', u'filter', u'hdu', 'object', u'visit']"
            

            Merlin Fisher-Levine has an idea of writing a translate method which, for example, allows --id object='DomeFlat' to select any file with DomeFlat-* in its OBJECT header. I leave that to his future ticket.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thank you Merlin Fisher-Levine for reviewing and testing. Merged to master. For future reference, the DM-5902 workaround was added only for using raw with the object key. It can be used in Merlin's example such as: constructBias.py repo/root --id object= 'DomeFlat-g40' ..... The workaround is not added for the proposal key but DM-5902 will solve that. Before it's solve, an error like below is expected when running CmdLineTasks with --id proposal=abc error: "Unrecognized ID key 'proposal'; valid keys are: ['ccdnum', u'date', u'filter', u'hdu', 'object', u'visit']" Merlin Fisher-Levine has an idea of writing a translate method which, for example, allows --id object='DomeFlat' to select any file with DomeFlat-* in its OBJECT header. I leave that to his future ticket.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            See DM-10198 for the ticket requesting support for globs in data selection.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - See DM-10198 for the ticket requesting support for globs in data selection.

              People

              • Assignee:
                hchiang2 Hsin-Fang Chiang
                Reporter:
                price Paul Price
                Reviewers:
                Merlin Fisher-Levine
                Watchers:
                Colin Slater, Hsin-Fang Chiang, Merlin Fisher-Levine, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel