Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Measurement-S14-3, Measurement-S14-4
-
Team:Data Release Production
Description
In DM-384 and DM-242, we disabled the periods-to-underscores translations for new tables ("version 1") but left it in place for old tables ("version 0"). In addition, when reading a table without a version number, we assumed it was version 0, to maintain backwards compatibility.
I think we should modify this slightly: we should assume a table without a version number is version 0 if and only if it also has the AFW_TYPE key. Otherwise we should assume it is version 1. This will allow us to load externally-produced tables without turning any underscores they contain into periods, while still maintaining backwards compatibility with older tables written by afw.
Attachments
Activity
Perry Gee
added a comment - Meant to say it is in tickets/ DM-590 
This is a very simple change to afw.table so that if a FITS TABLE which was not written by afw::table is read into a BaseCatalog, the schema version will appear to be the current default type (Schema.DEFAULT_VERSION)
src/table/io/FitsReader.cc | 8 +++++++-
tests/testSimpleTable.py | 14 ++++++++++++++
This should be a very quick review.