Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5922

Rework camera geometry to use the replacement for XYTransform

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      8
    • Sprint:
      Alert Production S17 - 4, Alert Production S17 - 5, Alert Production S17 - 6, Alert Production F17 - 7, Alert Production F17 - 8, Alert Production F17 - 9
    • Team:
      Alert Production

      Description

      As part of overhauling XYTransform we will likely need to replace the way we describe the transformations supported by camera geometry and Detector. This is likely to include a new way of describing the coordinate frames (e.g. PIXEL. FOCAL_PLANE and PUPIL).

      If we adopt AST (as seems likely) then these frames will be AST Frames, the transforms will be AST Mappings and the collection described by Camera and Detector will be one or more AST FrameSets.

      An RFC for the redesigned API for camera geometry will be required and this ticket is to implement the resulting design.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Review complete. I only had comments on a few packages, and I don't have anything to add beyond what's in the PRs.

            Show
            jbosch Jim Bosch added a comment - Review complete. I only had comments on a few packages, and I don't have anything to add beyond what's in the PRs.
            Hide
            rowen Russell Owen added a comment -

            Kian-Tat Lim I would like to add an initial short private section to the class TransformMap in order to define a private struct needed for the return type from a public iterator interface (begin and end). The struct should be private, but is part of the return type from begin and end. I am officially petitioning you for permission.

            Show
            rowen Russell Owen added a comment - Kian-Tat Lim I would like to add an initial short private section to the class TransformMap in order to define a private struct needed for the return type from a public iterator interface ( begin and end ). The struct should be private, but is part of the return type from begin and end . I am officially petitioning you for permission.
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            It might be more accurate to say it is needed to define the return type; I don't think it's "part of" it in the sense that you can get it back out or make queries about it.

            Show
            krzys Krzysztof Findeisen added a comment - - edited It might be more accurate to say it is needed to define the return type; I don't think it's "part of" it in the sense that you can get it back out or make queries about it.
            Hide
            ktl Kian-Tat Lim added a comment -

            Wait, I saw this already

            https://github.com/lsst/afw/pull/271#discussion_r135886388

            I approve.

            (The caveat was whether GetKey might possibly be useful to any user of TransformMap; if you have determined that it is not, and it indeed seems unlikely, then you're good to go.)

            Show
            ktl Kian-Tat Lim added a comment - Wait, I saw this already https://github.com/lsst/afw/pull/271#discussion_r135886388 I approve. (The caveat was whether GetKey might possibly be useful to any user of TransformMap ; if you have determined that it is not, and it indeed seems unlikely, then you're good to go.)
            Hide
            rowen Russell Owen added a comment -

            There is at least one sims package yet to merge, but my part of this is done.

            Show
            rowen Russell Owen added a comment - There is at least one sims package yet to merge, but my part of this is done.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Jim Bosch, Paul Price
                Watchers:
                Jim Bosch, John Parejko, Kian-Tat Lim, Krzysztof Findeisen, Merlin Fisher-Levine, Michael Wood-Vasey, Paul Price, Russell Owen, Scott Daniel, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel