Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5966

Remove use of Boost smart pointers in meas extensions

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Removal of boost smart pointers in DM-5879 missed some meas extensions which are not built as part of lsst_distrib. Namely: meas_extensions_shapeHSM, meas_extensions_simpleShape and meas_extensions_photometryKron.
      Update these too.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5879 Remove use of Boost smart pointers throughout the Science Pipelines

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-100 Switch from boost::shared_ptr to std::shared_ptr

          • Implemented
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-6080 afw build failure with XCode 6.2 (OSX 10.9)

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6084 meas_algorithms cannot be built with XCode 7.2.1

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2141 Add meas_extensions_shapeHSM to lsstsw, lsst_distrib

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3440 add meas_extensions_photometryKron to lsstsw, lsst_distrib

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            10 older comments
            Hide
            Permalink
            price Paul Price added a comment -

            Changes are two lines with s/boost/std/ — fine.

            Show
            price Paul Price added a comment - Changes are two lines with s/boost/std/ — fine.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Sorry for the dumb question, but – I don't see any outstanding pull requests against _shapeHSM, I don't see any tickets that refer to it and to Boost smart pointers, and the last merge to master was nearly a month ago. In what sense has it been taken care of?

            Show
            swinbank John Swinbank added a comment - Sorry for the dumb question, but – I don't see any outstanding pull requests against _shapeHSM , I don't see any tickets that refer to it and to Boost smart pointers, and the last merge to master was nearly a month ago. In what sense has it been taken care of?
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            In the sense that I see:

            commit e378129462947a18d3da95100c878173f3f72207
            		 
            Author: Paul Price <price@astro.princeton.edu>
            		 
            Date:   Wed May 4 20:08:21 2016 -0400
            		 
             
            		 
                remove use of boost:: in favour of std::
            		 
                
                The one exception is ImageConverter._owner, because that's passed
            		 
                to GalSim, which uses boost::shared_ptr.

            which I think came in with the rebase on tickets/DM-2141. I don't know which ticket this belongs to, or if it has been merged to master. Just assumed that it was on its way in.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited In the sense that I see: commit e378129462947a18d3da95100c878173f3f72207 Author: Paul Price <price@astro.princeton.edu> Date: Wed May 4 20:08:21 2016 -0400   remove use of boost:: in favour of std:: The one exception is ImageConverter._owner, because that's passed to GalSim, which uses boost::shared_ptr. which I think came in with the rebase on tickets/ DM-2141 . I don't know which ticket this belongs to, or if it has been merged to master. Just assumed that it was on its way in.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Ah, got it – looks like it'll get merged with DM-2141. Fine. Thanks.

            Show
            swinbank John Swinbank added a comment - Ah, got it – looks like it'll get merged with DM-2141 . Fine. Thanks.
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            The standard library on older OSX releases seems to be broken which causes various issues.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - The standard library on older OSX releases seems to be broken which causes various issues.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Paul Price
              Watchers:
              John Swinbank, Paul Price, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: