Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5966

Remove use of Boost smart pointers in meas extensions

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Removal of boost smart pointers in DM-5879 missed some meas extensions which are not built as part of lsst_distrib. Namely: meas_extensions_shapeHSM, meas_extensions_simpleShape and meas_extensions_photometryKron.
      Update these too.

        Attachments

          Issue Links

            Activity

            pschella Pim Schellart [X] (Inactive) created issue -
            pschella Pim Schellart [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-5395 [ 23202 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Link This issue is triggered by DM-5879 [ DM-5879 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggered by RFC-100 [ RFC-100 ]
            swinbank John Swinbank made changes -
            Epic Link DM-5395 [ 23202 ] DM-5346 [ 23141 ]
            swinbank John Swinbank made changes -
            Epic Link DM-5346 [ 23141 ] DM-5246 [ 22969 ]
            Hide
            swinbank John Swinbank added a comment -

            I've now added _photometryKron to the lsstsw system, so you can build it through Jenkins (specify product meas_extensions_photometryKron. Predictably, it's currently failing (error: could not convert 'boost::make_shared, etc etc).

            Show
            swinbank John Swinbank added a comment - I've now added _photometryKron to the lsstsw system, so you can build it through Jenkins (specify product meas_extensions_photometryKron . Predictably, it's currently failing ( error: could not convert 'boost::make_shared , etc etc).
            swinbank John Swinbank made changes -
            Link This issue relates to DM-3440 [ DM-3440 ]
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            Thanks! meas_extensions_photometryKron now builds on branch tickets/DM-5966. It is quite slow though.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited Thanks! meas_extensions_photometryKron now builds on branch tickets/ DM-5966 . It is quite slow though.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            There is no CI for meas_extensions_shapeHSM. So can only test that locally.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - There is no CI for meas_extensions_shapeHSM . So can only test that locally.
            Hide
            swinbank John Swinbank added a comment -

            _shapeHSM is listed in the repos.yaml file for lsstsw, so it ought to be buildable with Jenkins. What's the issue?

            Show
            swinbank John Swinbank added a comment - _shapeHSM is listed in the repos.yaml file for lsstsw , so it ought to be buildable with Jenkins. What's the issue?
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Product meas_extensions_shapeHSM does not exist. But perhaps I mistyped (or did something else wrong).

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Product meas_extensions_shapeHSM does not exist. But perhaps I mistyped (or did something else wrong).
            Hide
            swinbank John Swinbank added a comment -

            I think you must've mistyped: it's there, but it's currently broken on master. I think tickets/DM-2141 is good to go – see here for build currently in progress.

            Show
            swinbank John Swinbank added a comment - I think you must've mistyped: it's there, but it's currently broken on master . I think tickets/ DM-2141 is good to go – see here for build currently in progress.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Ah, probably true I'm now getting:

            GalSim: 1.3.2.lsst1 ERROR (0 sec).
            *** error building product GalSim.
            *** exit code = 1
            *** log is in /home/build0/lsstsw/build/GalSim/_build.log
            *** last few lines:
            :::::  [2016-05-04T23:24:17.741342Z] + EUPS_PATH=/home/build0/lsstsw/stack
            :::::  [2016-05-04T23:24:17.741352Z] + cd /home/build0/lsstsw/build/GalSim
            :::::  [2016-05-04T23:24:17.741358Z] + git reset --hard
            :::::  [2016-05-04T23:24:17.742942Z] HEAD is now at 3282f97 Merge pull request #9 from lsst/u/mjuric/fix-eupspkg
            :::::  [2016-05-04T23:24:17.743054Z] + git clean -d -f -q -x -e '_build.*'
            :::::  [2016-05-04T23:24:17.744210Z] + eupspkg PRODUCT=GalSim VERSION=1.3.2.lsst1 FLAVOR=generic prep
            :::::  [2016-05-04T23:24:18.101655Z] + cat
            :::::  [2016-05-04T23:24:18.102535Z] + set +x
            :::::  [2016-05-04T23:24:18.102560Z] Setting up environment with EUPS
            :::::  [2016-05-04T23:24:18.153765Z] setup: in file /home/build0/lsstsw/build/GalSim/ups/galsim.table: Product numpy not found
            Failed during rebuild of DM stack.
            

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Ah, probably true I'm now getting: GalSim: 1.3.2.lsst1 ERROR (0 sec). *** error building product GalSim. *** exit code = 1 *** log is in /home/build0/lsstsw/build/GalSim/_build .log *** last few lines: ::::: [2016-05-04T23:24:17.741342Z] + EUPS_PATH= /home/build0/lsstsw/stack ::::: [2016-05-04T23:24:17.741352Z] + cd /home/build0/lsstsw/build/GalSim ::::: [2016-05-04T23:24:17.741358Z] + git reset --hard ::::: [2016-05-04T23:24:17.742942Z] HEAD is now at 3282f97 Merge pull request #9 from lsst/u/mjuric/fix-eupspkg ::::: [2016-05-04T23:24:17.743054Z] + git clean -d -f -q -x -e '_build.*' ::::: [2016-05-04T23:24:17.744210Z] + eupspkg PRODUCT=GalSim VERSION=1.3.2.lsst1 FLAVOR=generic prep ::::: [2016-05-04T23:24:18.101655Z] + cat ::::: [2016-05-04T23:24:18.102535Z] + set +x ::::: [2016-05-04T23:24:18.102560Z] Setting up environment with EUPS ::::: [2016-05-04T23:24:18.153765Z] setup: in file /home/build0/lsstsw/build/GalSim/ups/galsim .table: Product numpy not found Failed during rebuild of DM stack.
            Hide
            swinbank John Swinbank added a comment -

            That looks like the problem which should be fixed on tickets/DM-2141. Try rebasing your work on top of that?

            Show
            swinbank John Swinbank added a comment - That looks like the problem which should be fixed on tickets/ DM-2141 . Try rebasing your work on top of that?
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Of course, that is what you meant. Will do that, but tomorrow since evidently I'm too tired at the moment to think.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Of course, that is what you meant. Will do that, but tomorrow since evidently I'm too tired at the moment to think.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            It seems that Paul Price has already taken care of meas_extensions_shapeHSM so I just created a pull request for the changes in meas_extensions_photometryKron. Ready for merge. Note that meas_extensions_simpleShape didn't need any modifications.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited It seems that Paul Price has already taken care of meas_extensions_shapeHSM so I just created a pull request for the changes in meas_extensions_photometryKron . Ready for merge. Note that meas_extensions_simpleShape didn't need any modifications.
            pschella Pim Schellart [X] (Inactive) made changes -
            Reviewers Paul Price [ price ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            price Paul Price added a comment -

            Changes are two lines with s/boost/std/ — fine.

            Show
            price Paul Price added a comment - Changes are two lines with s/boost/std/ — fine.
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            swinbank John Swinbank added a comment -

            Sorry for the dumb question, but – I don't see any outstanding pull requests against _shapeHSM, I don't see any tickets that refer to it and to Boost smart pointers, and the last merge to master was nearly a month ago. In what sense has it been taken care of?

            Show
            swinbank John Swinbank added a comment - Sorry for the dumb question, but – I don't see any outstanding pull requests against _shapeHSM , I don't see any tickets that refer to it and to Boost smart pointers, and the last merge to master was nearly a month ago. In what sense has it been taken care of?
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment - - edited

            In the sense that I see:

            commit e378129462947a18d3da95100c878173f3f72207
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed May 4 20:08:21 2016 -0400
             
                remove use of boost:: in favour of std::
                
                The one exception is ImageConverter._owner, because that's passed
                to GalSim, which uses boost::shared_ptr.
            

            which I think came in with the rebase on tickets/DM-2141. I don't know which ticket this belongs to, or if it has been merged to master. Just assumed that it was on its way in.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - - edited In the sense that I see: commit e378129462947a18d3da95100c878173f3f72207 Author: Paul Price <price@astro.princeton.edu> Date: Wed May 4 20:08:21 2016 -0400   remove use of boost:: in favour of std:: The one exception is ImageConverter._owner, because that's passed to GalSim, which uses boost::shared_ptr. which I think came in with the rebase on tickets/ DM-2141 . I don't know which ticket this belongs to, or if it has been merged to master. Just assumed that it was on its way in.
            Hide
            swinbank John Swinbank added a comment -

            Ah, got it – looks like it'll get merged with DM-2141. Fine. Thanks.

            Show
            swinbank John Swinbank added a comment - Ah, got it – looks like it'll get merged with DM-2141 . Fine. Thanks.
            swinbank John Swinbank made changes -
            Link This issue relates to DM-2141 [ DM-2141 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            The standard library on older OSX releases seems to be broken which causes various issues.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - The standard library on older OSX releases seems to be broken which causes various issues.
            pschella Pim Schellart [X] (Inactive) made changes -
            Link This issue is triggering DM-6080 [ DM-6080 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Link This issue is triggering DM-6084 [ DM-6084 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13634 ] This issue links to "Page (Confluence)" [ 13634 ]

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                Paul Price
                Watchers:
                John Swinbank, Paul Price, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel