Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6061

File descriptor leak in pex_logging

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_logging
    • Labels:
      None
    • Team:
      Architecture

      Description

      Debugging DM-5979 demonstrated that the using addDestination on the default logger leads to a file descriptor leak. If it's called once in a long running process there is obviously no issue but in a test framework where many tests are being executed within a single process and where resource leaks are tracked this can be bad. At best the file descriptor leak testing code will trigger a leak and the test must be disabled, at worst as tests continue to add new destinations the logger can be bogged down in sending messages to more and more locations.

      The simplest fix for testing frameworks may be to simply add a removeDestination method that can remove the destination that was added by the test.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            This ticket can be closed as irrelevant once DM-8365 has been implemented.

            Show
            tjenness Tim Jenness added a comment - This ticket can be closed as irrelevant once DM-8365 has been implemented.
            Hide
            tjenness Tim Jenness added a comment -

            Now that pex_logging is deprecated this will not be fixed.

            Show
            tjenness Tim Jenness added a comment - Now that pex_logging is deprecated this will not be fixed.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Hsin-Fang Chiang, Kian-Tat Lim, Steve Pietrowicz, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.