Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6089

Use fixed width integer types from std instead of boost

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The following fixed width integer types are used in the stack:

      • boost::int16_t
      • boost::int32_t
      • boost::int64_t
      • boost::int8_t
      • boost::uint16_t
      • boost::uint32_t
      • boost::uint64_t
      • boost::uint8_t

      This ticket aims to replace them with their equivalents from cstdint.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            CI run complete. Won't merge before release.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - CI run complete. Won't merge before release.
            Hide
            swinbank John Swinbank added a comment -

            What's the rationale for delaying the merge? The release isn't frozen yet. Do we expect this to cause significant breakage?

            (I'm not saying this should go in, I'd just like to understand what discussions have taken place.)

            Show
            swinbank John Swinbank added a comment - What's the rationale for delaying the merge? The release isn't frozen yet. Do we expect this to cause significant breakage? (I'm not saying this should go in, I'd just like to understand what discussions have taken place.)
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Given that CI worked and the changes are small I don't foresee any problems, but you never know really and it's not worth risking introducing release blocking issues for. Plus DM-6080 and DM-6084 got Jim worried so he asked me to delay further deboostification until after the release.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Given that CI worked and the changes are small I don't foresee any problems, but you never know really and it's not worth risking introducing release blocking issues for. Plus DM-6080 and DM-6084 got Jim worried so he asked me to delay further deboostification until after the release.
            Hide
            swinbank John Swinbank added a comment -

            Given that the release has been tagged, are you now comfortable with merging this? I would hate to see it delayed into F16.

            Show
            swinbank John Swinbank added a comment - Given that the release has been tagged, are you now comfortable with merging this? I would hate to see it delayed into F16.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            I am perfectly comfortable with merging all remaining Boost cleanup tickets. I am just waiting for the reviews

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - I am perfectly comfortable with merging all remaining Boost cleanup tickets. I am just waiting for the reviews
            Hide
            nlust Nate Lust added a comment -

            looks good to me

            Show
            nlust Nate Lust added a comment - looks good to me
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged after final CI run and cleanup of unnecessary includes.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged after final CI run and cleanup of unnecessary includes.

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, John Swinbank, Nate Lust, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: