Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-609

afw unit tests not built unless afwdata available

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:

      Description

      If afw_data is not available then the afw unit tests are not built. I think it would make more sense to build all of them and run those we can (not all depend on afw_data). One advantage is that a version of afw installed using "eups distrib install" would include built tests, so the tests could be run. This is presently not practical because the SConstruct file is not installed (I intend to open a ticket about that, as well).

        Attachments

          Issue Links

            Activity

            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Hi Tim!
            Could you please give this ticket a review? I've used unittesst.skipIf to skip the Python tests that depend on afwdata and Boost UTF utf::enabled() & utf::disabled() decorators to skip c++ tests that depend on afwdata. Four c++ test suites that depend on afwdata aren't written using the Boost UTF framework which makes it difficult to skip individual tests. For now, for these four test suites, the whole test suite is skipped if afwdata is not setup. I have created DM-5843 to refactor these four suites (and any others that were not affected by this ticket) to use the Boost UTF.

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Hi Tim! Could you please give this ticket a review? I've used unittesst.skipIf to skip the Python tests that depend on afwdata and Boost UTF utf::enabled() & utf::disabled() decorators to skip c++ tests that depend on afwdata. Four c++ test suites that depend on afwdata aren't written using the Boost UTF framework which makes it difficult to skip individual tests. For now, for these four test suites, the whole test suite is skipped if afwdata is not setup. I have created DM-5843 to refactor these four suites (and any others that were not affected by this ticket) to use the Boost UTF.
            Hide
            tjenness Tim Jenness added a comment -

            Thanks for this. I've made some comments on the PR regarding some confusion I have and some issues with duplicated afwdata testing. I've run the tests (non binaries) with py.test to get the skip statistics:

            36 failed, 677 passed, 106 skipped, 4 pytest-warnings, 1 error in 97.12 seconds
            

            Those failures are for another ticket (DM-5561 will explain more on possible reasons) that I should probably file.

            Show
            tjenness Tim Jenness added a comment - Thanks for this. I've made some comments on the PR regarding some confusion I have and some issues with duplicated afwdata testing. I've run the tests (non binaries) with py.test to get the skip statistics: 36 failed, 677 passed, 106 skipped, 4 pytest-warnings, 1 error in 97.12 seconds Those failures are for another ticket ( DM-5561 will explain more on possible reasons) that I should probably file.
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Tim Jenness Can you take one last look. I've just changed the c++ tests that require afwdata so that they are enabled by default and skipped in the SConstruct file if afwdata is not setup. I'm testing on Jenkins now....

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Tim Jenness Can you take one last look. I've just changed the c++ tests that require afwdata so that they are enabled by default and skipped in the SConstruct file if afwdata is not setup. I'm testing on Jenkins now....
            Hide
            tjenness Tim Jenness added a comment -

            That does work. I hadn't noticed the arguments there removing tests from the command. It's a shame that boost hasn't got a scheme for printing out skip counts. We'll have to revisit some of this when DM-5561 is merged.

            Show
            tjenness Tim Jenness added a comment - That does work. I hadn't noticed the arguments there removing tests from the command. It's a shame that boost hasn't got a scheme for printing out skip counts. We'll have to revisit some of this when DM-5561 is merged.
            Hide
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Merged to master....

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Merged to master....

              People

              Assignee:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tim Jenness
              Watchers:
              Jim Bosch, John Swinbank, Kian-Tat Lim, Mario Juric, Robert Lupton, Russell Owen, Tim Jenness, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: