Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6090

Replace boost::lexical_cast with std::to_string where possible

    Details

    • Type: Story
    • Status: Done
    • Priority: Minor
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Templates:
    • Story Points:
      0
    • Sprint:
      DRP X16-3, DRP F16-1
    • Team:
      Data Release Production

      Description

      Use std::to_string for integer to string conversions instead of boost::lexical_cast.
      Also investigate how often `boost::lexical_cast` is used for the inverse operation and make appropriate replacements if possible.

        Issue Links

          Activity

          Hide
          pschella Pim Schellart added a comment -

          Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy. Two different solutions are given in two commits and I need an ok on one of them.
          CI build works in both cases.

          Show
          pschella Pim Schellart added a comment - Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy . Two different solutions are given in two commits and I need an ok on one of them. CI build works in both cases.
          Hide
          swinbank John Swinbank added a comment -

          Hey Kian-Tat Lim – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?

          Show
          swinbank John Swinbank added a comment - Hey Kian-Tat Lim – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?
          Hide
          swinbank John Swinbank added a comment -

          SPs captured in parent issue.

          Show
          swinbank John Swinbank added a comment - SPs captured in parent issue.
          Hide
          ktl Kian-Tat Lim added a comment -

          Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.

          Show
          ktl Kian-Tat Lim added a comment - Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.
          Hide
          pschella Pim Schellart added a comment -

          Merged after final CI run.

          Show
          pschella Pim Schellart added a comment - Merged after final CI run.

            People

            • Assignee:
              pschella Pim Schellart
              Reporter:
              pschella Pim Schellart
              Reviewers:
              Kian-Tat Lim
              Watchers:
              John Swinbank, Kian-Tat Lim, Pim Schellart
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile