Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6090

Replace boost::lexical_cast with std::to_string where possible

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 0
    • DRP X16-3, DRP F16-1
    • Data Release Production

    Description

      Use std::to_string for integer to string conversions instead of boost::lexical_cast.
      Also investigate how often `boost::lexical_cast` is used for the inverse operation and make appropriate replacements if possible.

      Attachments

        Issue Links

          Activity

            Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy. Two different solutions are given in two commits and I need an ok on one of them.
            CI build works in both cases.

            pschella Pim Schellart [X] (Inactive) added a comment - Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy . Two different solutions are given in two commits and I need an ok on one of them. CI build works in both cases.

            Hey ktl – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?

            swinbank John Swinbank added a comment - Hey ktl – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?

            SPs captured in parent issue.

            swinbank John Swinbank added a comment - SPs captured in parent issue.
            ktl Kian-Tat Lim added a comment -

            Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.

            ktl Kian-Tat Lim added a comment - Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.

            Merged after final CI run.

            pschella Pim Schellart [X] (Inactive) added a comment - Merged after final CI run.

            People

              pschella Pim Schellart [X] (Inactive)
              pschella Pim Schellart [X] (Inactive)
              Kian-Tat Lim
              John Swinbank, Kian-Tat Lim, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.