# Replace boost::lexical_cast with std::to_string where possible

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
None
• Story Points:
0
• Sprint:
DRP X16-3, DRP F16-1
• Team:
Data Release Production

## Description

Use std::to_string for integer to string conversions instead of boost::lexical_cast.
Also investigate how often boost::lexical_cast is used for the inverse operation and make appropriate replacements if possible.

## Activity

Hide
Pim Schellart [X] (Inactive) added a comment -

Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy. Two different solutions are given in two commits and I need an ok on one of them.
CI build works in both cases.

Show
Pim Schellart [X] (Inactive) added a comment - Mostly trivial changes. The only slightly non trivial thing is a minor problem with casting in a throw in Definition::validateBasic in pex_policy . Two different solutions are given in two commits and I need an ok on one of them. CI build works in both cases.
Hide
John Swinbank added a comment -

Hey Kian-Tat Lim – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?

Show
John Swinbank added a comment - Hey Kian-Tat Lim – it would be great if we could close this before the end of the cycle. Any chance you'll find time to take a look?
Hide
John Swinbank added a comment -

SPs captured in parent issue.

Show
John Swinbank added a comment - SPs captured in parent issue.
Hide
Kian-Tat Lim added a comment -

Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.

Show
Kian-Tat Lim added a comment - Since Policy will be going away relatively soon anyway, I'm fine with not including the previous value in the exception; the name is sufficient anyway.
Hide
Pim Schellart [X] (Inactive) added a comment -

Merged after final CI run.

Show
Pim Schellart [X] (Inactive) added a comment - Merged after final CI run.

## People

• Assignee:
Pim Schellart [X] (Inactive)
Reporter:
Pim Schellart [X] (Inactive)
Reviewers:
Kian-Tat Lim
Watchers:
John Swinbank, Kian-Tat Lim, Pim Schellart [X] (Inactive)