Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6092

Remove use of boost::noncopyable

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Replace by deleting copy constructor.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Pim Schellart [X] suggests I might want to weigh in here, so: my preference is for explicit deletion rather than a mixin. But it's sufficiently slight that I wouldn't have bothered mentioning it if Pim hadn't asked, so I'm certainly not going to complain if you jump in the other direction.

            Show
            swinbank John Swinbank added a comment - Pim Schellart [X] suggests I might want to weigh in here, so: my preference is for explicit deletion rather than a mixin. But it's sufficiently slight that I wouldn't have bothered mentioning it if Pim hadn't asked, so I'm certainly not going to complain if you jump in the other direction.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Ok, so given nobody (including me) has a strong preference, and assuming John Parejko doesn't object, I'm going with the explicit delete option. It seems to offer the least amount of possible limitations in the future.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Ok, so given nobody (including me) has a strong preference, and assuming John Parejko doesn't object, I'm going with the explicit delete option. It seems to offer the least amount of possible limitations in the future.
            Hide
            Parejkoj John Parejko added a comment -

            Given that my only objection was overruled (not without good reason!), this is ok to merge.

            Show
            Parejkoj John Parejko added a comment - Given that my only objection was overruled (not without good reason!), this is ok to merge.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged after final CI run. Thank you for the review!

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged after final CI run. Thank you for the review!
            Hide
            swinbank John Swinbank added a comment -

            SPs contained in parent issue.

            Show
            swinbank John Swinbank added a comment - SPs contained in parent issue.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              John Parejko
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: