Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6094

Use type traits from type_traits over boost equivalents where possible

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The following are used:

      • boost::call_traits
      • boost::enable_if
      • boost::enable_if_c
      • boost::false_type
      • boost::is_arithmetic
      • boost::is_complex
      • boost::is_const
      • boost::is_convertible
      • boost::is_integral
      • boost::is_same
      • boost::remove_const
      • boost::true_type

      Replace these with equivalents from std where possible.

        Attachments

          Issue Links

            Activity

            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Removed boost::is_any_of from this ticket because it is not a type trait.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Removed boost::is_any_of from this ticket because it is not a type trait.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Now using the following from std instead of boost.

            • is_same
            • is_const
            • is_arithmetic
            • is_integral
            • remove_const

            The others in the list were either restricted to ndarray (outside of scope for this ticket) or just had unused includes.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Now using the following from std instead of boost . is_same is_const is_arithmetic is_integral remove_const The others in the list were either restricted to ndarray (outside of scope for this ticket) or just had unused includes.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Less work than I thought. CI build completed successfully.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Less work than I thought. CI build completed successfully.
            Hide
            swinbank John Swinbank added a comment -

            Couple of minor comments on the PR. Otherwise, good to go.

            Show
            swinbank John Swinbank added a comment - Couple of minor comments on the PR . Otherwise, good to go.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged after final CI build, changes based on comments and updating of copyright statements.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged after final CI build, changes based on comments and updating of copyright statements.
            Hide
            swinbank John Swinbank added a comment -

            SPs contained in parent issue.

            Show
            swinbank John Swinbank added a comment - SPs contained in parent issue.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: