Details

    • Type: Story
    • Status: Done
    • Priority: Minor
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Templates:
    • Story Points:
      0
    • Sprint:
      DRP X16-3
    • Team:
      Data Release Production

      Description

      Replace boost::ref

        Issue Links

          Activity

          Hide
          pschella Pim Schellart added a comment -

          The STL unfortunately doesn't have an equivalent for boost::unwrap_reference and boost::unwrap_ref. We can easily make one, but that might not be desirable.

          Show
          pschella Pim Schellart added a comment - The STL unfortunately doesn't have an equivalent for boost::unwrap_reference and boost::unwrap_ref . We can easily make one, but that might not be desirable.
          Hide
          pschella Pim Schellart added a comment -

          If we do make one, we need to decide where to put it.

          Show
          pschella Pim Schellart added a comment - If we do make one, we need to decide where to put it.
          Hide
          jbosch Jim Bosch added a comment -

          I think most (all?) use of boost::ref can now be avoided via use of universal references (or at least I think of boost::ref a workaround for the lack of perfect forwarding). Those changes might not be trivial, however; if they aren't we should probably just defer this ticket.

          Show
          jbosch Jim Bosch added a comment - I think most (all?) use of boost::ref can now be avoided via use of universal references (or at least I think of boost::ref a workaround for the lack of perfect forwarding). Those changes might not be trivial, however; if they aren't we should probably just defer this ticket.
          Hide
          pschella Pim Schellart added a comment -

          Yes, that is probably true. I’ll try and see if it can be done quickly. Otherwise let’s defer it.

          Show
          pschella Pim Schellart added a comment - Yes, that is probably true. I’ll try and see if it can be done quickly. Otherwise let’s defer it.
          Hide
          pschella Pim Schellart added a comment -

          CI successfully completed.

          Show
          pschella Pim Schellart added a comment - CI successfully completed.
          Hide
          jbosch Jim Bosch added a comment -

          One small comment in afw (on the PR), where I don't quite understand how what you've done works, but otherwise looks fine.

          Show
          jbosch Jim Bosch added a comment - One small comment in afw (on the PR), where I don't quite understand how what you've done works, but otherwise looks fine.
          Hide
          pschella Pim Schellart added a comment -

          Merged

          Show
          pschella Pim Schellart added a comment - Merged
          Hide
          swinbank John Swinbank added a comment -

          SPs contained in parent issue.

          Show
          swinbank John Swinbank added a comment - SPs contained in parent issue.

            People

            • Assignee:
              pschella Pim Schellart
              Reporter:
              pschella Pim Schellart
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile