Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6096

Replace boost::scoped_array with std::unique_ptr specialisation

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Replace boost::scoped_array with std::unique_ptr specialisation

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Code looks fine. Minor comments on PRs, but they are all formatting/presentation issues. In addition, please note the guidance on git commit summary lines, and try to stick to <= 50 characters when possible.

            I note that the ndarray and partition packages in the lsst organization both contain scoped_arrays that you aren't touching. I assume the former is following discussion with Jim, and the latter is because you regard Qserv as off limits. Is that right? Have you discussed it with the Qserv team?

            I assume you've checked that this builds and passes tests on both Jenkins and your Mac. If so, and once you've addressed the minor issues above, good to merge.

            Show
            swinbank John Swinbank added a comment - Code looks fine. Minor comments on PRs, but they are all formatting/presentation issues. In addition, please note the guidance on git commit summary lines , and try to stick to <= 50 characters when possible. I note that the ndarray and partition packages in the lsst organization both contain scoped_arrays that you aren't touching. I assume the former is following discussion with Jim, and the latter is because you regard Qserv as off limits. Is that right? Have you discussed it with the Qserv team? I assume you've checked that this builds and passes tests on both Jenkins and your Mac. If so, and once you've addressed the minor issues above, good to merge.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            CI build and merge complete.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - CI build and merge complete.
            Hide
            swinbank John Swinbank added a comment -

            SPs contained in parent issue.

            Show
            swinbank John Swinbank added a comment - SPs contained in parent issue.

              People

              • Assignee:
                pschella Pim Schellart [X] (Inactive)
                Reporter:
                pschella Pim Schellart [X] (Inactive)
                Reviewers:
                John Swinbank
                Watchers:
                John Swinbank, Pim Schellart [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: