Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:0
-
Epic Link:
-
Sprint:DRP X16-3
-
Team:Data Release Production
Description
Replace boost::scoped_array with std::unique_ptr specialisation
Attachments
Issue Links
Activity
Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you 
Pim Schellart [X] (Inactive)
added a comment - Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you CI build and merge complete.
Pim Schellart [X] (Inactive)
added a comment - CI build and merge complete. SPs contained in parent issue.
Code looks fine. Minor comments on PRs, but they are all formatting/presentation issues. In addition, please note the guidance on git commit summary lines, and try to stick to <= 50 characters when possible.
I note that the ndarray and partition packages in the lsst organization both contain scoped_arrays that you aren't touching. I assume the former is following discussion with Jim, and the latter is because you regard Qserv as off limits. Is that right? Have you discussed it with the Qserv team?
I assume you've checked that this builds and passes tests on both Jenkins and your Mac. If so, and once you've addressed the minor issues above, good to merge.