[DM-6096] Replace boost::scoped_array with std::unique_ptr specialisation - Jira

Pim Schellart [X] (Inactive) created issue - 13/May/16 11:51 AM

Pim Schellart [X] (Inactive) made changes - 13/May/16 11:51 AM

Field	Original Value	New Value
Link		This issue is child task of ~~DM-5880~~ [ ~~DM-5880~~ ]

John Swinbank made changes - 16/May/16 6:00 AM

Epic Link

~~DM-5346~~ [ 23141 ]

John Swinbank made changes - 16/May/16 6:00 AM

Team

Data Release Production [ 10301 ]

Pim Schellart [X] (Inactive) made changes - 23/May/16 11:47 AM

Status

To Do [ 10001 ]

In Progress [ 3 ]

Pim Schellart [X] (Inactive) made changes - 23/May/16 8:40 PM

Status	In Progress [ 3 ]	In Review [ 10004 ]
Reviewers		John Swinbank [ swinbank ]

Hide

Permalink

John Swinbank added a comment - 24/May/16 4:16 AM

Code looks fine. Minor comments on PRs, but they are all formatting/presentation issues. In addition, please note the guidance on git commit summary lines, and try to stick to <= 50 characters when possible.

I note that the ndarray and partition packages in the lsst organization both contain scoped_arrays that you aren't touching. I assume the former is following discussion with Jim, and the latter is because you regard Qserv as off limits. Is that right? Have you discussed it with the Qserv team?

I assume you've checked that this builds and passes tests on both Jenkins and your Mac. If so, and once you've addressed the minor issues above, good to merge.

Show

John Swinbank added a comment - 24/May/16 4:16 AM Code looks fine. Minor comments on PRs, but they are all formatting/presentation issues. In addition, please note the guidance on git commit summary lines , and try to stick to <= 50 characters when possible. I note that the ndarray and partition packages in the lsst organization both contain scoped_arrays that you aren't touching. I assume the former is following discussion with Jim, and the latter is because you regard Qserv as off limits. Is that right? Have you discussed it with the Qserv team? I assume you've checked that this builds and passes tests on both Jenkins and your Mac. If so, and once you've addressed the minor issues above, good to merge.

John Swinbank made changes - 24/May/16 4:16 AM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Hide

Permalink

Pim Schellart [X] (Inactive) added a comment - 24/May/16 7:12 AM

Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you

Show

Pim Schellart [X] (Inactive) added a comment - 24/May/16 7:12 AM Yes, I did indeed left out those packages for those reasons. I have not discussed it with the Qserv team because I based that decision on a discussion with you

Hide

Permalink

Pim Schellart [X] (Inactive) added a comment - 24/May/16 10:59 AM

CI build and merge complete.

Show

Pim Schellart [X] (Inactive) added a comment - 24/May/16 10:59 AM CI build and merge complete.

Pim Schellart [X] (Inactive) made changes - 24/May/16 10:59 AM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Hide

Permalink

John Swinbank added a comment - 03/Jun/16 5:12 AM

SPs contained in parent issue.

Show

John Swinbank added a comment - 03/Jun/16 5:12 AM SPs contained in parent issue.

John Swinbank made changes - 03/Jun/16 5:12 AM

Story Points

0

John Swinbank made changes - 06/Jun/16 5:57 AM

Remote Link