Fix Version/s: None
RFC-190 and mask suspect pixels:
Add selectLevel to lsst.afw.cameraGeom.AmpInfoCatalog, as a double, and add support for it to lsst.ip.isr.IsrTask, analogously to masking saturation: iif suspectLevel is not nan then set the SUSPECT flag for pixels above the suspect level.
Also change the type of saturation in the AmpInfoCatalog from int to double, so that the existing test for nan actually works
Nate Lust please review the obs packages, starting with obs_subaru
John Parejko please review the changes to the other packages (ip_isr, daf_butlerUtils, and afw)
Either of you should feel free to comment on any other changes you like, but by splitting this I hoped to give you a break.
I reviewed the non obs_* stuff, and I'm happy with the changes Russell's made post-review.
The obs_* stuff all looks benign and reasonable. I am a bit bothered by the values in fits files being unable to be displayed, that probably indicates some weird formatting written to the files, but that exists before this ticket so there is no reason to look into now.
It looks as though a whole bunch of stuff in obs_subaru got blown away with very little explanation in the course of this ticket: we're told that it was "outdated", but not what the replacements are, and it doesn't seem to have been discussed here at all. Can somebody explain what happened?
The deleted code was a broken method of generating camera geometry information from a paf file. The code and paf file are gone because that is deprecated. It can be resurrected from git history should Subaru decide it wants to generate its camera geometry information from a text file, instead of directly modifying the generated results.
RFC-192 for more information. Permission was given on the HipChat in the HSC Synchronization room. Given that this was removing broken code, nobody seemed to feel that an RFC or wider review was necessary.
Note that I took a different route for CFHT because the generating code was less broken (it ran but gave slightly incorrect results): the outdated code is marked as deprecated and prints a warning if used. I figured the folks maintaining obs_cfht could figure out what to do next based on the outcome of