Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-622

Qserv configuration tool refactoring

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      9.5
    • Sprint:
      DB_S14_06, DB_S14_07, DB_S14_08
    • Team:
      Data Access and Database

      Description

      • Instance configuration should not be in the same directory where qserv software is installed
        Qserv configuration, including things like mysql or zookeeper data directory should be separate from where Qserv software is installed. At the moment, when I want to work with branch "a" and "b", in order to switch from one to the other I have to run "cd $QSERV_DIR/admin; scons". This is ok the very first time after I created a branch, but it is way too heavy afterwards, because it wipes out all data from zookeeper and mysql.

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            Hi Fabrice,

            I made another round of install, few more small remarks:

            1. qserv-configure.py produces a lot of output which could be confusing if people try to look at it and understand it. It may be better to reduce it to something that just indicates that each step is completed successfully. If we want verbose output it could be redirected to a log file. This could go into separate ticket.
            2. qserv-configure.py managed to confuse me with this warning/question:

              WARNING : Do you want to update client configuration currently pointing on /usr/local/home/salnikov/.lsst/qserv.conf [y/n]

              I guess the intent was to ask if user config file needs to be updated. Maybe the question needs to be re-phrased and made less alarming? Something like:

              Do you want to update user configuration file ($HOME/.lsst/qserv.conf) for new run directory? [y/n]

            3. Making $HOME/.lsst/qserv.conf a symlink is probably OK for now in "mono" setup, but could be problematic in more general case because run directory does not have to be accessible from all machines. We need to think how to handle config files better.
            4. README file still says to run qserv-start.sh without full path name which assumes it's in a $PATH. Needs to be updated

            If you can fix 2 and 4 quickly I promise I will close review (I'm traveling back to US tomorrow).

            Show
            salnikov Andy Salnikov added a comment - Hi Fabrice, I made another round of install, few more small remarks: qserv-configure.py produces a lot of output which could be confusing if people try to look at it and understand it. It may be better to reduce it to something that just indicates that each step is completed successfully. If we want verbose output it could be redirected to a log file. This could go into separate ticket. qserv-configure.py managed to confuse me with this warning/question: WARNING : Do you want to update client configuration currently pointing on /usr/local/home/salnikov/.lsst/qserv.conf [y/n] I guess the intent was to ask if user config file needs to be updated. Maybe the question needs to be re-phrased and made less alarming? Something like: Do you want to update user configuration file ($HOME/.lsst/qserv.conf) for new run directory? [y/n] Making $HOME/.lsst/qserv.conf a symlink is probably OK for now in "mono" setup, but could be problematic in more general case because run directory does not have to be accessible from all machines. We need to think how to handle config files better. README file still says to run qserv-start.sh without full path name which assumes it's in a $PATH. Needs to be updated If you can fix 2 and 4 quickly I promise I will close review (I'm traveling back to US tomorrow).
            Hide
            jammes Fabrice Jammes added a comment -

            Thanks Andy,

            1. Has been reported in DM-954.
            2. The file referenced in the warning message is the target of symlink $HOME/.lsst/qserv.conf. That's why it is strange the first time you run it : indeed $HOME/.lsst/qserv.conf isn't a symlink but a real file. Message is much clearer with previous execution of qserv-configure.py.
              I've integrated your message proposal.
            3. I agree with you about this point.
            4. Updated (README isn't completely consistent with the code, as part of it is in DM-930, which was created from current master tip and not from DM-622 in order to be rebased easilly)

            Hope you'll have a nice travel

            Show
            jammes Fabrice Jammes added a comment - Thanks Andy, Has been reported in DM-954 . The file referenced in the warning message is the target of symlink $HOME/.lsst/qserv.conf. That's why it is strange the first time you run it : indeed $HOME/.lsst/qserv.conf isn't a symlink but a real file. Message is much clearer with previous execution of qserv-configure.py. I've integrated your message proposal. I agree with you about this point. Updated (README isn't completely consistent with the code, as part of it is in DM-930 , which was created from current master tip and not from DM-622 in order to be rebased easilly) Hope you'll have a nice travel
            Hide
            salnikov Andy Salnikov added a comment -

            OK, done. Finally

            Show
            salnikov Andy Salnikov added a comment - OK, done. Finally
            Hide
            salnikov Andy Salnikov added a comment -

            I think all is OK, for the list of packages in README file we should wait until new eups version is installed with Fabrice's new feature and then fix README.

            Show
            salnikov Andy Salnikov added a comment - I think all is OK, for the list of packages in README file we should wait until new eups version is installed with Fabrice's new feature and then fix README.
            Hide
            jbecla Jacek Becla added a comment -

            can this issue be closed now?

            Show
            jbecla Jacek Becla added a comment - can this issue be closed now?

              People

              Assignee:
              jammes Fabrice Jammes
              Reporter:
              fritzm Fritz Mueller
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Fabrice Jammes, Jacek Becla, Kian-Tat Lim
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: