Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_cfht
-
Labels:
-
Story Points:0.5
-
Epic Link:
-
Sprint:Alert Production X16 - 5
-
Team:Alert Production
Description
In DM-5524 Paul Price fixed the vertical overscan by directly editing the amp info catalogs, but didn't mark the camera generating code as bad. In DM-6147 I regenerated the files, reintroducing the problem. The problem seems to be a subtle bug in the camera generating code. Rather than try to fix it, I'll convert the fixed catalogs directly and mark the generating code as broken. Paul Price will issue an RFC that suggests a better way to handle generating amp info and once that is dealt with we can come up with a more permanent fix (e.g. delete the generating code or fix it).
Looking at a random CCD:
pprice@tiger-sumire:~/LSST/obs/cfht (tickets/DM-6246=) $ python -c 'from lsst.afw.table import AmpInfoCatalog; ccd = AmpInfoCatalog.readFits("megacam/camera/ccd13.fits"); print [amp.getRawVerticalOverscanBBox() for amp in ccd]'
[Box2I(Point2I(32, 4612), Extent2I(1023, 31)), Box2I(Point2I(1056, 4612), Extent2I(1023, 31))]
I think these should be Extent2I(1024, 32). Dominique Boutigny says on
DM-5524:Why have all the comments been removed from the megacam/camera/camera.py file?