Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6279

Fix possible logic error in pex_policy dictionary

    Details

    • Type: Bug
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: pex_policy
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Data Access and Database

      Description

      Investigate and fix the following warning in pex_policy.

      src/Dictionary.cc:312:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
          if (!getType() == Policy::POLICY) // should have checked this at a higher level
              ^          ~~
      src/Dictionary.cc:312:9: note: add parentheses after the '!' to evaluate the comparison first
          if (!getType() == Policy::POLICY) // should have checked this at a higher level
              ^
               (                          )
      src/Dictionary.cc:312:9: note: add parentheses around left hand side expression to silence this warning
          if (!getType() == Policy::POLICY) // should have checked this at a higher level
              ^
              (         )
      src/Dictionary.cc:312:20: warning: comparison of constant 'POLICY' (5) with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]
          if (!getType() == Policy::POLICY) // should have checked this at a higher level
      

        Attachments

          Activity

          Hide
          swinbank John Swinbank added a comment - - edited

          I think pex_policy is, at least nominally, out of scope for DRP. Who would you like to handle this, Kian-Tat Lim & Jacek Becla?

          Show
          swinbank John Swinbank added a comment - - edited I think pex_policy is, at least nominally, out of scope for DRP. Who would you like to handle this, Kian-Tat Lim & Jacek Becla ?
          Hide
          jbecla Jacek Becla added a comment -

          Since it is ncsa wbs, I'd assign to Proc Middleware team

          Show
          jbecla Jacek Becla added a comment - Since it is ncsa wbs, I'd assign to Proc Middleware team
          Hide
          swinbank John Swinbank added a comment -

          Done. Hsin-Fang Chiang may wish to take note.

          Show
          swinbank John Swinbank added a comment - Done. Hsin-Fang Chiang may wish to take note.

            People

            • Assignee:
              Unassigned
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Watchers:
              Jacek Becla, John Swinbank, Kian-Tat Lim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Summary Panel