Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6296

Wrap afw::geom with pybind11

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • None
    • 10
    • DRP F16-3, DRP F16-4
    • Data Release Production

    Description

      The generated wrappers will live parallel to the Swig wrappers. This ticket only covers the C++ wrappers themselves, not the Python layer on top (which will continue to use the old wrappers) all work will stay on a separate branch and will not be merged to master until DM-6168 is complete.

      Attachments

        Issue Links

          Activity

            Now passes all tests which only import lsst.afw.geom (and lsst.afw.coord). Implemented on branch for DM-7057.

            pschella Pim Schellart [X] (Inactive) added a comment - - edited Now passes all tests which only import lsst.afw.geom (and lsst.afw.coord ). Implemented on branch for DM-7057 .

            Passes all geom and coord only unit tests.
            But a lot of stuff may still be lurking in the other tests. Will tackle those as part of wrapping other parts of afw.
            Note that this PR will be merged to the epic branch, not to master.

            pschella Pim Schellart [X] (Inactive) added a comment - Passes all geom and coord only unit tests. But a lot of stuff may still be lurking in the other tests. Will tackle those as part of wrapping other parts of afw. Note that this PR will be merged to the epic branch, not to master.

            pschella – realistically, I'm not going to be able to give this a proper review in the foreseeable future. Sorry! Maybe Nate or Russell could help out?

            swinbank John Swinbank added a comment - pschella – realistically, I'm not going to be able to give this a proper review in the foreseeable future. Sorry! Maybe Nate or Russell could help out?
            tjenness Tim Jenness added a comment -

            That's a lot of code. Minor comments on the PR. Looks good.

            tjenness Tim Jenness added a comment - That's a lot of code. Minor comments on the PR. Looks good.

            Merged into ticket branch for epic after implementing requested changes.
            I also added the requested toString functions to Coord (and subclasses) and Observatory and use them for _str and repr_.

            pschella Pim Schellart [X] (Inactive) added a comment - Merged into ticket branch for epic after implementing requested changes. I also added the requested toString functions to Coord (and subclasses) and Observatory and use them for _ str and repr _ .

            People

              pschella Pim Schellart [X] (Inactive)
              pschella Pim Schellart [X] (Inactive)
              Tim Jenness
              John Swinbank, Pim Schellart [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.