Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6297

Wrap afw::detection with pybind11

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      5
    • Epic Link:
    • Sprint:
      DRP S17-1
    • Team:
      Data Release Production

      Description

      The generated wrappers will live parallel to the Swig wrappers. This ticket only covers the C++ wrappers themselves, not the Python layer on top (which will continue to use the old wrappers) all work will stay on a separate branch and will not be merged to master until DM-8467 is complete.

      The tests included in this ticket are:

      1. testExposureTable.py
      2. testFootprint1.py
      3. testFootprint2.py
      4. testFootprintEllipse.py
      5. testFootprintMergeCatalog.py
      6. testGaussianPsf.py
      7. testHeavyFootprint.py
      8. testRgb.py
      9. testTicket2019.py

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7057 Complete afw port to pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8434 Wrap leftover tests in afw with pybind11

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Looks good to me (other than a few nitpicky comments I made on the afw::detection branch).

            Show
            fred3m Fred Moolekamp added a comment - Looks good to me (other than a few nitpicky comments I made on the afw::detection branch).
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged after implementing changes requested by reviewer.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged after implementing changes requested by reviewer.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              pschella Pim Schellart [X] (Inactive)
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.