Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6300

Extend galaxy shear fitting results to cover ngmix

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_extensions_ngmix
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      DRP F16-1, DRP F16-2
    • Team:
      Data Release Production

      Attachments

        Issue Links

          Activity

          Hide
          pgee Perry Gee added a comment -

          Some changes had to be made to the LMSimpleShape plugin. These were of two types:

          (1) I changed the code to use the LMShape Runner at Erin's suggestion, and included a "Guesser" instead of creating a guess by myself.

          (2) I changed the output of LMSimpleShape to include several output values from the final fit, including x,y,flux,e1, and e2.

          I formerly believed that these could all be derived using a MultipleShapeletFunction created from the Gaussian mixture (recorded as a set of Gaussian ShapeletFunctions). But our MSF has limitations which meant that I had to use the GMix values produced by Erin's code.

          Show
          pgee Perry Gee added a comment - Some changes had to be made to the LMSimpleShape plugin. These were of two types: (1) I changed the code to use the LMShape Runner at Erin's suggestion, and included a "Guesser" instead of creating a guess by myself. (2) I changed the output of LMSimpleShape to include several output values from the final fit, including x,y,flux,e1, and e2. I formerly believed that these could all be derived using a MultipleShapeletFunction created from the Gaussian mixture (recorded as a set of Gaussian ShapeletFunctions). But our MSF has limitations which meant that I had to use the GMix values produced by Erin's code.
          Hide
          jbosch Jim Bosch added a comment -

          Looks good; my only comments (on the PR) are cosmetic, but still need to be addressed before merging (including the comment on the PR main page about the commit message).

          Show
          jbosch Jim Bosch added a comment - Looks good; my only comments (on the PR) are cosmetic, but still need to be addressed before merging (including the comment on the PR main page about the commit message).
          Hide
          pgee Perry Gee added a comment -

          Modification made per review
          Ran Jenkins build successfully

          Show
          pgee Perry Gee added a comment - Modification made per review Ran Jenkins build successfully
          Hide
          tjenness Tim Jenness added a comment -

          I'm a bit confused that this ticket is closed but the associated pull request is still open.

          Show
          tjenness Tim Jenness added a comment - I'm a bit confused that this ticket is closed but the associated pull request is still open.
          Hide
          swinbank John Swinbank added a comment -

          Looks like a rebased version was merged without being pushed to Github.

          Show
          swinbank John Swinbank added a comment - Looks like a rebased version was merged without being pushed to Github.

            People

            Assignee:
            pgee Perry Gee
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Jim Bosch, John Swinbank
            Watchers:
            Jim Bosch, John Swinbank, Perry Gee, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.