Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6303

Wrap ndarray with pybind11

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ndarray
    • Labels:
      None
    • Story Points:
      12
    • Sprint:
      DRP F16-1, DRP F16-2
    • Team:
      Data Release Production

      Attachments

        Activity

        Hide
        pschella Pim Schellart [X] (Inactive) added a comment -

        Ok, thanks for the input! Now ready for a second look!
        Besides the changes mentioned, it also includes type_casters for ndarray::EigenView and Eigen::Array.

        Show
        pschella Pim Schellart [X] (Inactive) added a comment - Ok, thanks for the input! Now ready for a second look! Besides the changes mentioned, it also includes type_casters for ndarray::EigenView and Eigen::Array .
        Hide
        jbosch Jim Bosch added a comment -

        Looks good. There are a few trivial comments on the PR (unfortunately, they appear to have been made on an "outdated diff" due to the spelling commit, so you'll have to click to expand them).

        Show
        jbosch Jim Bosch added a comment - Looks good. There are a few trivial comments on the PR (unfortunately, they appear to have been made on an "outdated diff" due to the spelling commit, so you'll have to click to expand them).
        Hide
        pschella Pim Schellart [X] (Inactive) added a comment -

        Thanks! I assume we will merge this to the epic branch again? And you will merge it upstream (if wanted)?

        Show
        pschella Pim Schellart [X] (Inactive) added a comment - Thanks! I assume we will merge this to the epic branch again? And you will merge it upstream (if wanted)?
        Hide
        jbosch Jim Bosch added a comment -

        Yes, we'll merge it to the epic branch. I may wait on merging it upstream until we try doing it with Pybind11's NumyPy interface, but if that takes too long (e.g. if we want to switch to upstream before doing that) I'll merge it as-is.

        Show
        jbosch Jim Bosch added a comment - Yes, we'll merge it to the epic branch. I may wait on merging it upstream until we try doing it with Pybind11's NumyPy interface, but if that takes too long (e.g. if we want to switch to upstream before doing that) I'll merge it as-is.
        Hide
        pschella Pim Schellart [X] (Inactive) added a comment -

        Merged onto epic branch (i.e. DM-6168)

        Show
        pschella Pim Schellart [X] (Inactive) added a comment - Merged onto epic branch (i.e. DM-6168 )

          People

          • Assignee:
            pschella Pim Schellart [X] (Inactive)
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Summary Panel