Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-6318

Update bin.src/validate_drp.py to handle missing "requirements" gracefully.

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Validation
    • Labels:
      None

      Description

      When I run examples/runDecamQuickTest.sh I get the following failure (using master c1ea4c0):

      /Users/rowen/UW/LSST/lsstsw/miniconda/lib/python2.7/site-packages/scipy/optimize/minpack.py:690: OptimizeWarning: Covariance of the parameters could not be estimated
        category=OptimizeWarning)
      Traceback (most recent call last):
        File "/Users/rowen/UW/LSST/testdata/validate_drp/bin/validateDrp.py", line 89, in <module>
          if args.configFile and kwargs['requirements']:
      KeyError: 'requirements'
      Validation failed
      

      Michael Wood-Vasey traced it to the following code:

      if args.configFile and kwargs['requirements']:
      

      and suggested the following change:

      if args.configFile and "requirements" in kwargs:
      

        Attachments

          Activity

          Hide
          krughoff Simon Krughoff added a comment -

          Looks great. Merge away.

          Show
          krughoff Simon Krughoff added a comment - Looks great. Merge away.
          Hide
          wmwood-vasey Michael Wood-Vasey added a comment -

          Merged to master.

          Show
          wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

            People

            • Assignee:
              wmwood-vasey Michael Wood-Vasey
              Reporter:
              rowen Russell Owen
              Reviewers:
              Simon Krughoff
              Watchers:
              Michael Wood-Vasey, Russell Owen, Simon Krughoff
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: